From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7A2o-00088v-6f for qemu-devel@nongnu.org; Mon, 22 Jun 2015 18:18:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7A2k-0006O4-Vm for qemu-devel@nongnu.org; Mon, 22 Jun 2015 18:18:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33518 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7A2k-0006Nr-Pb for qemu-devel@nongnu.org; Mon, 22 Jun 2015 18:18:18 -0400 Message-ID: <558889A7.2020408@suse.de> Date: Tue, 23 Jun 2015 00:18:15 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1434984574-21037-1-git-send-email-dgilbert@redhat.com> In-Reply-To: <1434984574-21037-1-git-send-email-dgilbert@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Peek dont read for vmdescription List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, quintela@redhat.com On 22.06.15 16:49, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The VMDescription section maybe after the EOF mark, the current code > does a 'qemu_get_byte' and either gets the header byte identifying the > description or an error (which it ignores). Doing the 'get' upsets > RDMA which hangs on old machine types without the VMDescription. > > Using 'qemu_peek_byte' avoids that. > > Signed-off-by: Dr. David Alan Gilbert Fun. I did actually use peek at first and then figured it's the same as read in the qemu file implementation. Have you figured out why exactly peek does make a difference for the RDMA case? Alex