From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z7DkQ-000234-MX
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:15:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z7DkL-0008JG-SV
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:15:38 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:44832)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Z7DkL-0008BV-3T
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:15:33 -0400
Message-ID: <5588C13E.10303@huawei.com>
Date: Tue, 23 Jun 2015 10:15:26 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1434646944-24040-1-git-send-email-berrange@redhat.com>
	<1434646944-24040-5-git-send-email-berrange@redhat.com>
In-Reply-To: <1434646944-24040-5-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 04/10] crypto: introduce generic cipher
 API & built-in implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Richard Henderson <rth@twiddle.net>

On 2015/6/19 1:02, Daniel P. Berrange wrote:
> Introduce a generic cipher API and an implementation of it that
> supports only the built-in AES and DES-RFB algorithms.
> 
> The test suite checks the supported algorithms + modes to
> validate that every backend implementation is actually correctly
> complying with the specs.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  crypto/Makefile.objs       |   1 +
>  crypto/cipher-builtin.c    | 398 +++++++++++++++++++++++++++++++++++++++++++++
>  crypto/cipher.c            |  50 ++++++
>  include/crypto/cipher.h    | 210 ++++++++++++++++++++++++
>  tests/.gitignore           |   1 +
>  tests/Makefile             |   2 +
>  tests/test-crypto-cipher.c | 290 +++++++++++++++++++++++++++++++++
>  7 files changed, 952 insertions(+)
>  create mode 100644 crypto/cipher-builtin.c
>  create mode 100644 crypto/cipher.c
>  create mode 100644 include/crypto/cipher.h
>  create mode 100644 tests/test-crypto-cipher.c

Reviewed-by: Gonglei <arei.gonglei@huawei.com>