From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7Dmv-0003av-Jk for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:18:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7Dmq-0000d4-QU for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:18:13 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:44383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7Dmq-0000cc-8s for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:18:08 -0400 Message-ID: <5588C1D3.4090700@huawei.com> Date: Tue, 23 Jun 2015 10:17:55 +0800 From: Gonglei MIME-Version: 1.0 References: <1434646944-24040-1-git-send-email-berrange@redhat.com> <1434646944-24040-8-git-send-email-berrange@redhat.com> In-Reply-To: <1434646944-24040-8-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 07/10] block: convert quorum blockdrv to use crypto APIs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Gerd Hoffmann , Richard Henderson On 2015/6/19 1:02, Daniel P. Berrange wrote: > Get rid of direct use of gnutls APIs in quorum blockdrv in > favour of using the crypto APIs. This avoids the need to > do conditional compilation of the quorum driver. It can > simply report an error at file open file instead if the > required hash algorithm isn't supported by QEMU. > > Signed-off-by: Daniel P. Berrange > --- > block/Makefile.objs | 2 +- > block/quorum.c | 41 ++++++++++++++++++++++------------------- > configure | 39 --------------------------------------- > 3 files changed, 23 insertions(+), 59 deletions(-) Reviewed-by: Gonglei