From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7Dmv-0003at-J8 for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:18:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7Dmu-0000eF-PF for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:18:13 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:46528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7Dmu-0000dc-2O for qemu-devel@nongnu.org; Mon, 22 Jun 2015 22:18:12 -0400 Message-ID: <5588C1DF.2060303@huawei.com> Date: Tue, 23 Jun 2015 10:18:07 +0800 From: Gonglei MIME-Version: 1.0 References: <1434646944-24040-1-git-send-email-berrange@redhat.com> <1434646944-24040-9-git-send-email-berrange@redhat.com> In-Reply-To: <1434646944-24040-9-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 08/10] ui: convert VNC websockets to use crypto APIs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Gerd Hoffmann , Richard Henderson On 2015/6/19 1:02, Daniel P. Berrange wrote: > Remove the direct use of gnutls for hash processing in the > websockets code, in favour of using the crypto APIs. This > allows the websockets code to be built unconditionally > removing countless conditional checks from the VNC code. > > Signed-off-by: Daniel P. Berrange > --- > configure | 19 +--------------- > ui/Makefile.objs | 2 +- > ui/vnc-ws.c | 22 +++++++++---------- > ui/vnc-ws.h | 2 -- > ui/vnc.c | 67 +++++++++++--------------------------------------------- > ui/vnc.h | 8 ------- > 6 files changed, 25 insertions(+), 95 deletions(-) Reviewed-by: Gonglei