From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver Date: Tue, 23 Jun 2015 11:06:19 +0800 Message-ID: <5588CD2B.3040807@rock-chips.com> References: <1434730417-10629-1-git-send-email-ykk@rock-chips.com> <1434731295-11060-1-git-send-email-ykk@rock-chips.com> <1434967564.31094.20.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1434967564.31094.20.camel@x220> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Bolle Cc: Fabio Estevam , alsa-devel , Liam Girdwood , linux-kernel@vger.kernel.org, dri-devel , Doug Anderson , linux-rockchip@lists.infradead.org, Mark Brown , Andy Yan , Russell King , Jaroslav Kysela , linux-arm-kernel List-Id: alsa-devel@alsa-project.org UGF1bCwKCuWcqCAyMDE1LzYvMjIgMTg6MDYsIFBhdWwgQm9sbGUg5YaZ6YGTOgo+IFNvbWV0aGlu ZyBJIGRpZG4ndCBub3RpY2UgaW4gdjQsIHNvcnJ5Lgo+Cj4gT24gU2F0LCAyMDE1LTA2LTIwIGF0 IDAwOjI4ICswODAwLCBZYWtpciBZYW5nIHdyb3RlOgo+PiAtLS0gL2Rldi9udWxsCj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS1pMnMtYXVkaW8uYwo+PiArI2RlZmluZSBE UklWRVJfTkFNRSAiZHctaGRtaS1pMnMtYXVkaW8iCj4+ICtNT0RVTEVfQUxJQVMoUExBVEZPUk1f TU9EVUxFX1BSRUZJWCBEUklWRVJfTkFNRSk7Cj4gMCkgU2lkZSBub3RlOiB0aGlzIGlzIHRoZSBm aXJzdCB0aW1lIHRoYXQgUExBVEZPUk1fTU9EVUxFX1BSRUZJWCBpcyB1c2VkCj4gaW5zaWRlIE1P RFVMRV9BTElBUygpLiBCdXQgbm9uZSBvZiB0aGUgMTAwMCsgb3RoZXIgInBsYXRmb3JtOiIgYWxp YXNlcwo+IGRvIHRoYXQuIEFuZCBuZWl0aGVyIGRvZXMgNS82IG9mIHRoaXMgc2VyaWVzISBUaGF0 IHN1Z2dlc3RzLCBJIHRoaW5rLAo+IHRoYXQgdGhpcyBzaG91bGRuJ3QgYmUgZG9uZS4KPgo+IFlv dSBjb3VsZCBjb25zaWRlciBhZGRpbmcgc29tZXRoaW5nIGxpa2UKPiAgICAgICNkZWZpbmUgTU9E VUxFX0FMSUFTX1BMQVRGT1JNKE5BTUUpIE1PRFVMRV9BTElBUyhQTEFURk9STV9NT0RVTEVfUFJF RklYIE5BTUUpCj4KPiBCdXQgdGhlbiwgSSB0aGluaywgYWxsIHRoZSBjdXJyZW50IDEwMDArIHBs YXRmb3JtOiBhbGlhc2VzIHNob3VsZCBiZQo+IGNvbnZlcnRlZCB0byB0aGF0IG1hY3JvLiBXb3Vs ZCB0aGF0IGJlIHdvcnRoIGl0PwpZZWFoLCBJdCB3b3VsZCBiZSBob3JyaWJsZSB0byBjb3ZlcnRl ZCB0byB0aGF0IG1hY3JvICA7KQoKPiAxKSBOb3cgb24gdG8gbXkgcmVtYXJrOiB0aGlzIGFsaWFz IHNlZW1zIHRvIGJlIG9ubHkgdXNlZnVsIGlmIHRoZXJlIGFsc28KPiBpcyBhIHN0cnVjdCBwbGF0 Zm9ybV9kZXZpY2Ugd2l0aCBhICJkdy1oZG1pLWkycy1hdWRpbyIgbmFtZS4gQmVjYXVzZQo+IHRo YXQgcGxhdGZvcm1fZGV2aWNlIHdvdWxkLCBiYWRseSBzdW1tYXJpemVkLCBmaXJlIG9mIGEKPiAi TU9EQUxJQVM9cGxhdGZvcm06ZHctaGRtaS1pMnMtYXVkaW8iIHVldmVudCB3aGVuIGNyZWF0ZWQu IFdoaWNoLCBpbiBpdHMKPiB0dXJuLCB3b3VsZCB0cmlnZ2VyIHVzZXJzcGFjZSB0byBsb2FkIHRo aXMgbW9kdWxlLCBjb3JyZWN0Pwo+Cj4gQnV0IEkgdGhpbmsgdGhlcmUncyBubyBwbGF0Zm9ybV9k ZXZpY2Ugd2l0aCBhICJkdy1oZG1pLWkycy1hdWRpbyIgbmFtZS4KPiBTbyBJIHdvbmRlciB3aGV0 aGVyIHRoaXMgTU9EVUxFX0FMSUFTKCkgaXMgYWN0dWFsbHkgbmVlZGVkLiBXaGF0IGJyZWFrcwo+ IGlmIHlvdSBsZWF2ZSBpdCBvdXQ/ClRoYW5rcyBmb3IgeW91ciBhdHRlbnRpdmUgY29tbWVudCAu ICBBY3R1YWxseSB0aGVyZSBzaG91bGQgYmUgYW4gCnBsYXRmb3JtIGRldmljZSB0aGF0IG5hbWVk ICJkdy1oZG1pLWkycy1hdWRpbyIgd2hpY2ggSSBtaXNzcGVsdCBpbiAKZHdfaGRtaS5jIGRyaXZl ci4KCnRoYW5rcywKLSBZYWtpcgoKPiAoTGlrZXdpc2UgZm9yIDUvNiwgYnV0IHRoZXJlIHRoZSBw bGF0Zm9ybV9kZXZpY2Ugc2hvdWxkIGhhdmUgYQo+ICJyb2NrY2hpcC1oZG1pLWF1ZGlvIiBuYW1l LikKPgo+IFRoYW5rcywKPgo+Cj4gUGF1bCBCb2xsZQo+Cj4KPgo+CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Tue, 23 Jun 2015 11:06:19 +0800 Subject: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver In-Reply-To: <1434967564.31094.20.camel@x220> References: <1434730417-10629-1-git-send-email-ykk@rock-chips.com> <1434731295-11060-1-git-send-email-ykk@rock-chips.com> <1434967564.31094.20.camel@x220> Message-ID: <5588CD2B.3040807@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Paul, ? 2015/6/22 18:06, Paul Bolle ??: > Something I didn't notice in v4, sorry. > > On Sat, 2015-06-20 at 00:28 +0800, Yakir Yang wrote: >> --- /dev/null >> +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c >> +#define DRIVER_NAME "dw-hdmi-i2s-audio" >> +MODULE_ALIAS(PLATFORM_MODULE_PREFIX DRIVER_NAME); > 0) Side note: this is the first time that PLATFORM_MODULE_PREFIX is used > inside MODULE_ALIAS(). But none of the 1000+ other "platform:" aliases > do that. And neither does 5/6 of this series! That suggests, I think, > that this shouldn't be done. > > You could consider adding something like > #define MODULE_ALIAS_PLATFORM(NAME) MODULE_ALIAS(PLATFORM_MODULE_PREFIX NAME) > > But then, I think, all the current 1000+ platform: aliases should be > converted to that macro. Would that be worth it? Yeah, It would be horrible to coverted to that macro ;) > 1) Now on to my remark: this alias seems to be only useful if there also > is a struct platform_device with a "dw-hdmi-i2s-audio" name. Because > that platform_device would, badly summarized, fire of a > "MODALIAS=platform:dw-hdmi-i2s-audio" uevent when created. Which, in its > turn, would trigger userspace to load this module, correct? > > But I think there's no platform_device with a "dw-hdmi-i2s-audio" name. > So I wonder whether this MODULE_ALIAS() is actually needed. What breaks > if you leave it out? Thanks for your attentive comment . Actually there should be an platform device that named "dw-hdmi-i2s-audio" which I misspelt in dw_hdmi.c driver. thanks, - Yakir > (Likewise for 5/6, but there the platform_device should have a > "rockchip-hdmi-audio" name.) > > Thanks, > > > Paul Bolle > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbbFWDGr (ORCPT ); Mon, 22 Jun 2015 23:06:47 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:38325 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109AbbFWDGj (ORCPT ); Mon, 22 Jun 2015 23:06:39 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: lgirdwood@gmail.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver To: Paul Bolle References: <1434730417-10629-1-git-send-email-ykk@rock-chips.com> <1434731295-11060-1-git-send-email-ykk@rock-chips.com> <1434967564.31094.20.camel@x220> Cc: linux-rockchip@lists.infradead.org, alsa-devel , dri-devel , linux-kernel@vger.kernel.org, linux-arm-kernel , Doug Anderson , David Airlie , Philipp Zabel , Russell King , Andy Yan , Daniel Kurtz , Fabio Estevam , Mark Brown , Takashi Iwai , Jaroslav Kysela , Heiko Stuebner , Liam Girdwood From: Yakir Yang Message-ID: <5588CD2B.3040807@rock-chips.com> Date: Tue, 23 Jun 2015 11:06:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1434967564.31094.20.camel@x220> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul, 在 2015/6/22 18:06, Paul Bolle 写道: > Something I didn't notice in v4, sorry. > > On Sat, 2015-06-20 at 00:28 +0800, Yakir Yang wrote: >> --- /dev/null >> +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c >> +#define DRIVER_NAME "dw-hdmi-i2s-audio" >> +MODULE_ALIAS(PLATFORM_MODULE_PREFIX DRIVER_NAME); > 0) Side note: this is the first time that PLATFORM_MODULE_PREFIX is used > inside MODULE_ALIAS(). But none of the 1000+ other "platform:" aliases > do that. And neither does 5/6 of this series! That suggests, I think, > that this shouldn't be done. > > You could consider adding something like > #define MODULE_ALIAS_PLATFORM(NAME) MODULE_ALIAS(PLATFORM_MODULE_PREFIX NAME) > > But then, I think, all the current 1000+ platform: aliases should be > converted to that macro. Would that be worth it? Yeah, It would be horrible to coverted to that macro ;) > 1) Now on to my remark: this alias seems to be only useful if there also > is a struct platform_device with a "dw-hdmi-i2s-audio" name. Because > that platform_device would, badly summarized, fire of a > "MODALIAS=platform:dw-hdmi-i2s-audio" uevent when created. Which, in its > turn, would trigger userspace to load this module, correct? > > But I think there's no platform_device with a "dw-hdmi-i2s-audio" name. > So I wonder whether this MODULE_ALIAS() is actually needed. What breaks > if you leave it out? Thanks for your attentive comment . Actually there should be an platform device that named "dw-hdmi-i2s-audio" which I misspelt in dw_hdmi.c driver. thanks, - Yakir > (Likewise for 5/6, but there the platform_device should have a > "rockchip-hdmi-audio" name.) > > Thanks, > > > Paul Bolle > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/