From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node_put() Date: Tue, 23 Jun 2015 10:32:02 +0530 Message-ID: <5588E84A.2000509@codeaurora.org> References: <1434984861-22948-1-git-send-email-architt@codeaurora.org> <1434984861-22948-2-git-send-email-architt@codeaurora.org> <5588311B.6030806@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5588311B.6030806@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Srinivas Kandagatla , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Ck9uIDA2LzIyLzIwMTUgMDk6MzAgUE0sIFNyaW5pdmFzIEthbmRhZ2F0bGEgd3JvdGU6Cj4KPgo+ IE9uIDIyLzA2LzE1IDE1OjU0LCBBcmNoaXQgVGFuZWphIHdyb3RlOgo+PiBEZWNyZW1lbnQgZGV2 aWNlIG5vZGUgcmVmY291bnQgaWYgb2ZfZ2V0X2NoaWxkX2J5X25hbWUgaXMgc3VjY2Vzc2Z1bGx5 Cj4+IGNhbGxlZC4KPj4KPj4gU2lnbmVkLW9mZi1ieTogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBj b2RlYXVyb3JhLm9yZz4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvZHNpX2hv c3QuYyB8IDIgKysKPj4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4+Cj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2RzaS9kc2lfaG9zdC5jCj4+IGIvZHJpdmVy cy9ncHUvZHJtL21zbS9kc2kvZHNpX2hvc3QuYwo+PiBpbmRleCBkZTA0MDA5Li4xNzUxNjU5IDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2RzaS9kc2lfaG9zdC5jCj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaV9ob3N0LmMKPj4gQEAgLTE1ODIsNiArMTU4Miw4 IEBAIGludCBtc21fZHNpX2hvc3RfcmVnaXN0ZXIoc3RydWN0IG1pcGlfZHNpX2hvc3QKPj4gKmhv c3QsIGJvb2wgY2hlY2tfZGVmZXIpCj4+ICAgICAgICAgICAgICAgbm9kZSA9IG9mX2dldF9jaGls ZF9ieV9uYW1lKG1zbV9ob3N0LT5wZGV2LT5kZXYub2Zfbm9kZSwKPj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgInBhbmVsIik7Cj4+ICAgICAgICAgICAgICAgaWYgKG5vZGUpIHsKPj4g KyAgICAgICAgICAgICAgICBvZl9ub2RlX3B1dChub2RlKTsKPj4gKwo+Cj4gQXRsZWFzdCBmcm9t IHRoZSBjdXJyZW50IHN0YXRlIG9mIGNvZGUsIEl0IGxvb2tzIGxpa2UgdGhlIGRyaXZlciBpcwo+ IGdvaW5nIHRvIHJlZmVyIHRvIHRoZSBub2RlIG9mX25vZGVfcHV0PywgU28gSSB0aGluayB0aGlz IGlzIG5vdCB0aGUKPiByaWdodCBwbGFjZSB0byBoYXZlIG9mX25vZGVfcHV0LgoKVGhhdCdzIHJp Z2h0LiBJIG1hZGUgdGhlIHNhbWUgbWlzdGFrZSBpbiB0aGUgbGF0ZXIgcGF0Y2hlcyB0b28uIEkn bGwgZml4IAp0aGVzZS4KClRoYW5rcywKQXJjaGl0CgotLSAKUXVhbGNvbW0gSW5ub3ZhdGlvbiBD ZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sCmEgTGludXggRm91 bmRhdGlvbiBDb2xsYWJvcmF0aXZlIFByb2plY3QKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751429AbbFWFCP (ORCPT ); Tue, 23 Jun 2015 01:02:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43836 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbbFWFCI (ORCPT ); Tue, 23 Jun 2015 01:02:08 -0400 Message-ID: <5588E84A.2000509@codeaurora.org> Date: Tue, 23 Jun 2015 10:32:02 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Srinivas Kandagatla , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org CC: robdclark@gmail.com, hali@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node_put() References: <1434984861-22948-1-git-send-email-architt@codeaurora.org> <1434984861-22948-2-git-send-email-architt@codeaurora.org> <5588311B.6030806@linaro.org> In-Reply-To: <5588311B.6030806@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/22/2015 09:30 PM, Srinivas Kandagatla wrote: > > > On 22/06/15 15:54, Archit Taneja wrote: >> Decrement device node refcount if of_get_child_by_name is successfully >> called. >> >> Signed-off-by: Archit Taneja >> --- >> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c >> b/drivers/gpu/drm/msm/dsi/dsi_host.c >> index de04009..1751659 100644 >> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c >> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c >> @@ -1582,6 +1582,8 @@ int msm_dsi_host_register(struct mipi_dsi_host >> *host, bool check_defer) >> node = of_get_child_by_name(msm_host->pdev->dev.of_node, >> "panel"); >> if (node) { >> + of_node_put(node); >> + > > Atleast from the current state of code, It looks like the driver is > going to refer to the node of_node_put?, So I think this is not the > right place to have of_node_put. That's right. I made the same mistake in the later patches too. I'll fix these. Thanks, Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/