All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Sheng Yong <shengyong1@huawei.com>,
	computersforpeace@gmail.com, dwmw2@infradead.org
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 0/2] mtd: nandsim: fix error handling
Date: Tue, 23 Jun 2015 08:26:40 +0200	[thread overview]
Message-ID: <5588FC20.4020600@nod.at> (raw)
In-Reply-To: <5588B07E.4080404@huawei.com>

Am 23.06.2015 um 03:03 schrieb Sheng Yong:
> Ping. Any comments are appreciated :)
> 
> thanks,
> Sheng
> 
> On 6/17/2015 4:45 PM, Sheng Yong wrote:
>> These 2 patches fix error handling when nandsim initialization fails.
>>
>> In alloc_device(), if creating slab memory fails, free_device() will try
>> to destroy the slab memory without checking if it exists.  PATCH 1 fixes
>> it.
>>
>> If something goes wrong in init_nandsim(), it calls free_device() before
>> returning. However, the caller of init_nandsim() - ns_init_module() - also
>> does the cleanup by calling free_nandsim(). This causes double free. PATCH
>> 2 fixes it.
>>
>> Thanks,
>> Sheng
>>
>> Sheng Yong (2):
>>   mtd: nandsim: fix free of NULL pointer
>>   mtd: nandsim: fix double free

Both patches look good to me.

Thanks,
//richard

  reply	other threads:[~2015-06-23  6:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17  8:45 [PATCH 0/2] mtd: nandsim: fix error handling Sheng Yong
2015-06-17  8:45 ` [PATCH 1/2] mtd: nandsim: fix free of NULL pointer Sheng Yong
2015-06-17  8:48   ` Richard Weinberger
2015-06-17  9:00     ` Richard Weinberger
2015-06-17  9:03     ` Sheng Yong
2015-06-17  9:05       ` Richard Weinberger
2015-06-17  8:45 ` [PATCH 2/2] mtd: nandsim: fix double free Sheng Yong
2015-06-23  1:03 ` [PATCH 0/2] mtd: nandsim: fix error handling Sheng Yong
2015-06-23  6:26   ` Richard Weinberger [this message]
2015-06-24  0:53     ` Sheng Yong
2015-06-23 21:59 ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5588FC20.4020600@nod.at \
    --to=richard@nod.at \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shengyong1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.