From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7Jef-0007C5-C3 for qemu-devel@nongnu.org; Tue, 23 Jun 2015 04:34:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7JeZ-00037F-T8 for qemu-devel@nongnu.org; Tue, 23 Jun 2015 04:34:05 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7JeZ-00036F-Ms for qemu-devel@nongnu.org; Tue, 23 Jun 2015 04:33:59 -0400 Received: by paceq1 with SMTP id eq1so2417182pac.3 for ; Tue, 23 Jun 2015 01:33:59 -0700 (PDT) Message-ID: <558919F5.1090906@igel.co.jp> Date: Tue, 23 Jun 2015 17:33:57 +0900 From: Tetsuya Mukawa MIME-Version: 1.0 References: <1434945048-27958-1-git-send-email-mukawa@igel.co.jp> <1434945048-27958-4-git-send-email-mukawa@igel.co.jp> <20150622095122-mutt-send-email-mst@redhat.com> In-Reply-To: <20150622095122-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/5] vhost-user: Shutdown vhost-user connection when wrong messages are passed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: jasowang@redhat.com, n.nikolaev@virtualopensystems.com, qemu-devel@nongnu.org, stefanha@redhat.com On 2015/06/22 16:54, Michael S. Tsirkin wrote: > On Mon, Jun 22, 2015 at 12:50:46PM +0900, Tetsuya Mukawa wrote: >> When wrong vhost-user message are passed, the connection should be shutdown. >> >> Signed-off-by: Tetsuya Mukawa > This silently changes the protocol semantics: previously > unknown messages were ignored. We can't do this. > See email titled "vhost-user: protocol extensions" which relies on this > to detect protocol version. > Hi Michael, Thanks for commenting. Instead of disconnecting the backend, I will add warning message and leave link status down. Regards, Tetsuya