Re: [PATCH v5 1/2] dt: add cap11xx LED documentation

[Jacek Anaszewski <j.anaszewski@samsung.com>]

On 06/22/2015 07:59 PM, Dmitry Torokhov wrote:
> On Wed, Jun 17, 2015 at 08:58:16PM -0700, Matt Ranostay wrote:
>> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
>> ---
>>   .../devicetree/bindings/input/cap11xx.txt          | 25 ++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/input/cap11xx.txt b/Documentation/devicetree/bindings/input/cap11xx.txt
>> index 7d0a300..09cdc43 100644
>> --- a/Documentation/devicetree/bindings/input/cap11xx.txt
>> +++ b/Documentation/devicetree/bindings/input/cap11xx.txt
>> @@ -38,6 +38,11 @@ Optional properties:
>>   				defaults. The array must have exactly six
>>   				entries.
>>
>> +	linux,led-brightness:	Defines the ON brightness when the optional LED
>> +				functionality is used. Valid values are 1-15.
>> +				By default a value of 15 is set.
>
> Please mention the device does not allow controlling brightness of leds
> individually and that is why this property is at device level, not
> individual led level.

I've just noticed that we have drivers/leds/leds-netxbig.c driver, which
also doesn't allow controlling the LEDs on extension board individually,
but it still does allow changing their brightness. I am leaning towards
allowing this also for this driver and adding similar comment in the
source code like at the line 218 of the aforementioned driver.
As a result this property wouldn't be required.

> Also, why does it have "linux" prefix? It does not appear to control
> any linux-specific functionality.


-- 
Best Regards,
Jacek Anaszewski