From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7KFs-0003pj-Br for qemu-devel@nongnu.org; Tue, 23 Jun 2015 05:12:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7KFp-0003g4-Na for qemu-devel@nongnu.org; Tue, 23 Jun 2015 05:12:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7KFp-0003fz-IT for qemu-devel@nongnu.org; Tue, 23 Jun 2015 05:12:29 -0400 Message-ID: <558922F9.9050105@redhat.com> Date: Tue, 23 Jun 2015 11:12:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1434646046-27150-1-git-send-email-pbonzini@redhat.com> <1434646046-27150-5-git-send-email-pbonzini@redhat.com> <20150623090531.GC2028@ad.nay.redhat.com> In-Reply-To: <20150623090531.GC2028@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/9] exec: pull qemu_flush_coalesced_mmio_buffer() into address_space_rw/ld*/st* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org On 23/06/2015 11:05, Fam Zheng wrote: >> > diff --git a/memory.c b/memory.c >> > index 6b77354..be385d4 100644 >> > --- a/memory.c >> > +++ b/memory.c >> > @@ -414,9 +414,6 @@ static MemTxResult memory_region_read_with_attrs_accessor(MemoryRegion *mr, >> > uint64_t tmp = 0; >> > MemTxResult r; >> > >> > - if (mr->flush_coalesced_mmio) { >> > - qemu_flush_coalesced_mmio_buffer(); >> > - } >> > r = mr->ops->read_with_attrs(mr->opaque, addr, &tmp, size, attrs); >> > trace_memory_region_ops_read(mr, addr, tmp, size); >> > *value |= (tmp & mask) << shift; >> > @@ -449,9 +446,6 @@ static MemTxResult memory_region_write_accessor(MemoryRegion *mr, >> > { >> > uint64_t tmp; >> > >> > - if (mr->flush_coalesced_mmio) { >> > - qemu_flush_coalesced_mmio_buffer(); >> > - } >> > tmp = (*value >> shift) & mask; >> > trace_memory_region_ops_write(mr, addr, tmp, size); >> > mr->ops->write(mr->opaque, addr, tmp, size); > Why are memory_region_read_accessor and memory_region_write_with_attrs_accessor > unchanged? Good catch. Botched the rebasing. Paolo