From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 07/11] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers Date: Tue, 23 Jun 2015 11:51:41 +0200 Message-ID: <55892C2D.1010407@redhat.com> References: <1434989108-20924-1-git-send-email-den@openvz.org> <1434989108-20924-8-git-send-email-den@openvz.org> <55892B49.3040507@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Peter Hornyack , kvm@vger.kernel.org, qemu-devel@nongnu.org, Andrey Smetanin , Gleb Natapov To: "Denis V. Lunev" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45027 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbbFWJvp (ORCPT ); Tue, 23 Jun 2015 05:51:45 -0400 In-Reply-To: <55892B49.3040507@openvz.org> Sender: kvm-owner@vger.kernel.org List-ID: On 23/06/2015 11:47, Denis V. Lunev wrote: >> >> The current implementation is potentially more flexible but makes the >> MSR handling a little more awkward since the host_initiated bool needs >> to be passed around (patch 09). I guess either approach seems ok to >> me. >> >> Also, if this patchset is used then it looks like >> HV_X64_MSR_CRASH_CTL_CONTENTS can be removed. > > Paolo, > > do you have any opinion on this? I prefer > configurable way but there is no problem > to enable it by default dropping 'hv_panic' > property. I also prefer the configurable way. Would hv_panic prevent reboot-on-BSOD from rebooting the VM? Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7Krt-0004JR-PP for qemu-devel@nongnu.org; Tue, 23 Jun 2015 05:51:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7Krq-0005c9-KU for qemu-devel@nongnu.org; Tue, 23 Jun 2015 05:51:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7Krq-0005c4-Ep for qemu-devel@nongnu.org; Tue, 23 Jun 2015 05:51:46 -0400 Message-ID: <55892C2D.1010407@redhat.com> Date: Tue, 23 Jun 2015 11:51:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1434989108-20924-1-git-send-email-den@openvz.org> <1434989108-20924-8-git-send-email-den@openvz.org> <55892B49.3040507@openvz.org> In-Reply-To: <55892B49.3040507@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/11] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Andrey Smetanin , Gleb Natapov , qemu-devel@nongnu.org, kvm@vger.kernel.org, Peter Hornyack On 23/06/2015 11:47, Denis V. Lunev wrote: >> >> The current implementation is potentially more flexible but makes the >> MSR handling a little more awkward since the host_initiated bool needs >> to be passed around (patch 09). I guess either approach seems ok to >> me. >> >> Also, if this patchset is used then it looks like >> HV_X64_MSR_CRASH_CTL_CONTENTS can be removed. > > Paolo, > > do you have any opinion on this? I prefer > configurable way but there is no problem > to enable it by default dropping 'hv_panic' > property. I also prefer the configurable way. Would hv_panic prevent reboot-on-BSOD from rebooting the VM? Paolo