From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: Bug in devicetree_for_each_node() in xen/arch/arm/bootfdt.c ? Date: Tue, 23 Jun 2015 11:01:36 +0100 Message-ID: <55892E80.8020507@citrix.com> References: <4EE5B48738DDED408878C97C8E050A8B1D7ABBB3@SJEXCHMB05.corp.ad.broadcom.com> <55892A93.905@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z7LFo-0006it-L9 for xen-devel@lists.xenproject.org; Tue, 23 Jun 2015 10:16:32 +0000 In-Reply-To: <55892A93.905@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , "Chris (Christopher) Brand" , "xen-devel@lists.xenproject.org" Cc: Ian Campbell List-Id: xen-devel@lists.xenproject.org Hi, On 23/06/2015 10:44, David Vrabel wrote: > On 23/06/15 00:02, Chris (Christopher) Brand wrote: >> I=92ve been trying to figure out why Xen only reports 2GB on my ARM >> platform that actually has 3GB, and I think I=92ve found a bug, but I=92m >> not familiar enough with the Xen code to fix it. >> >> The relevant parts of my dts are: >> >> /dts-v1/; >> / { >> >> model =3D "Broadcom STB (7445d0)"; >> compatible =3D "brcm,bcm7445d0", "brcm,brcmstb"; >> #address-cells =3D <0x2>; >> #size-cells =3D <0x2>; >> interrupt-parent =3D <0x1>; >> >> memory { >> #address-cells =3D <0x1>; >> #size-cells =3D <0x1>; >> device_type =3D "memory"; >> reg =3D <0x0 0x0 0x0 0x40000000 0x0 0x40000000 0x0 0x4000000= 0>; > > It's been a while since I've looked at device tree stuff but I think you > need 64-bit values for this reg property because the parent node has > #address-cells =3D=3D 0x2 and #size-cells =3D=3D 0x2. I think they are already on 64-bit values, otherwise you would have a = bank starting at 0 of a size 0 which seems odd. Anyway, the format of this memory node is not supported on Xen and I = wasn't able to find a bindings somewhere. Will extend my point by = answering to his mail. Cheers, -- = Julien Grall