From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [RFC PATCH 2/7] drm/i915: Read hw state into an atomic state struct, try 2. Date: Tue, 23 Jun 2015 12:49:00 +0200 Message-ID: <5589399C.7060400@linux.intel.com> References: <1434700950-16242-1-git-send-email-maarten.lankhorst@linux.intel.com> <1434700950-16242-3-git-send-email-maarten.lankhorst@linux.intel.com> <20150622153136.GT25769@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id B40A06E0DA for ; Tue, 23 Jun 2015 03:49:18 -0700 (PDT) In-Reply-To: <20150622153136.GT25769@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjItMDYtMTUgb20gMTc6MzEgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIEZyaSwgSnVu IDE5LCAyMDE1IGF0IDEwOjAyOjI1QU0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiAgLyogU2NhbiBvdXQgdGhlIGN1cnJlbnQgaHcgbW9kZXNldCBzdGF0ZSwgc2FuaXRpemVzIGl0 IGFuZCBtYXBzIGl0IGludG8gdGhlIGRybQo+PiBAQCAtMTU0OTEsMzcgKzE1NTY5LDYxIEBAIHZv aWQgaW50ZWxfbW9kZXNldF9zZXR1cF9od19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ PiAgCQkJCSAgYm9vbCBmb3JjZV9yZXN0b3JlKQo+PiAgewo+PiAgCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+IC0JZW51bSBwaXBlIHBpcGU7 Cj4+IC0Jc3RydWN0IGludGVsX2NydGMgKmNydGM7Cj4+ICsJc3RydWN0IGRybV9jcnRjICpjcnRj Owo+PiArCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPj4gIAlzdHJ1Y3QgaW50 ZWxfZW5jb2RlciAqZW5jb2RlcjsKPj4gKwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7 Cj4+ICsJc3RydWN0IGludGVsX3NoYXJlZF9kcGxsX2NvbmZpZyBzaGFyZWRfZHBsbHNbSTkxNV9O VU1fUExMU107Cj4+ICAJaW50IGk7Cj4+ICAKPj4gLQlpbnRlbF9tb2Rlc2V0X3JlYWRvdXRfaHdf c3RhdGUoZGV2KTsKPj4gLQo+PiAtCS8qCj4+IC0JICogTm93IHRoYXQgd2UgaGF2ZSB0aGUgY29u ZmlnLCBjb3B5IGl0IHRvIGVhY2ggQ1JUQyBzdHJ1Y3QKPj4gLQkgKiBOb3RlIHRoYXQgdGhpcyBj b3VsZCBnbyBhd2F5IGlmIHdlIG1vdmUgdG8gdXNpbmcgY3J0Y19jb25maWcKPj4gLQkgKiBjaGVj a2luZyBldmVyeXdoZXJlLgo+PiAtCSAqLwo+PiAtCWZvcl9lYWNoX2ludGVsX2NydGMoZGV2LCBj cnRjKSB7Cj4+IC0JCWlmIChjcnRjLT5hY3RpdmUgJiYgaTkxNS5mYXN0Ym9vdCkgewo+PiAtCQkJ aW50ZWxfbW9kZV9mcm9tX3BpcGVfY29uZmlnKCZjcnRjLT5iYXNlLm1vZGUsCj4+IC0JCQkJCQkg ICAgY3J0Yy0+Y29uZmlnKTsKPj4gLQkJCURSTV9ERUJVR19LTVMoIltDUlRDOiVkXSBmb3VuZCBh Y3RpdmUgbW9kZTogIiwKPj4gLQkJCQkgICAgICBjcnRjLT5iYXNlLmJhc2UuaWQpOwo+PiAtCQkJ ZHJtX21vZGVfZGVidWdfcHJpbnRtb2RlbGluZSgmY3J0Yy0+YmFzZS5tb2RlKTsKPj4gLQkJfQo+ PiArCXN0YXRlID0gaW50ZWxfbW9kZXNldF9yZWFkb3V0X2h3X3N0YXRlKGRldik7Cj4+ICsJaWYg KElTX0VSUihzdGF0ZSkpIHsKPj4gKwkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gcmVhZCBvdXQgaHcg c3RhdGVcbiIpOwo+PiArCQlyZXR1cm47Cj4+ICAJfQo+PiAgCj4+ICsJZHJtX2F0b21pY19oZWxw ZXJfc3dhcF9zdGF0ZShkZXYsIHN0YXRlKTsKPj4gKwo+PiArCS8qIHN3YXAgc3cvaHcgZHBsbCBz dGF0ZSAqLwo+PiArCWludGVsX2F0b21pY19kdXBsaWNhdGVfZHBsbF9zdGF0ZShkZXZfcHJpdiwg c2hhcmVkX2RwbGxzKTsKPj4gKwlpbnRlbF9zaGFyZWRfZHBsbF9jb21taXQoc3RhdGUpOwo+PiAr CW1lbWNweSh0b19pbnRlbF9hdG9taWNfc3RhdGUoc3RhdGUpLT5zaGFyZWRfZHBsbCwKPj4gKwkg ICAgICAgc2hhcmVkX2RwbGxzLCBzaXplb2YoKnNoYXJlZF9kcGxscykgKiBkZXZfcHJpdi0+bnVt X3NoYXJlZF9kcGxsKTsKPiBUaGlzIGlzIGltbyB3YXkgdG9vIG11Y2ggb3Blbi1jb2Rpbmcgb2Yg c3R1ZmYgdGhhdCdzIGFscmVhZHkgdGhlcmUuIFdoYXQgSQo+IGhhZCBpbiBtaW5kIGZvciBmb3Jj ZV9yZXN0b3JlIHdhcyBhIGdlbmVyaWMgaGVscGVyIHRvIGR1cGxpY2F0ZSBhbGwgdGhlCj4gc3Rh dGUgb2JqZWN0cyBpbnRvIGEgZHJtX2F0b21pY19zdGF0ZSwgd2l0aG91dCBjYWxsaW5nIGFueSBv ZiB0aGUKPiAtPmF0b21pY19jaGVjayBmdW5jdGlvbnMgb3IgYW55dGhpbmcuIFRoZW4gdGhlIHNl cXVlbmNlIGZvciByZXN0b3JpbmcKPiBzdGF0ZSB3b3VsZCBiZS4KPgo+IDEuIHNhdmVkX3N0YXRl ID0gZHJtX2F0b21pY19oZWxwZXJfZHVwbGljYXRlX3N0YXRlKCkKPiAyLiBpbnRlbF9yZWFkb3V0 X2h3X3NhdGUoKSA8LSB0aGlzIHdvdWxkIGp1c3QgdXBkYXRlIC0+c3RhdGUgYW5kIHNhbml0aXpl Cj4gaXQuCj4gMy4gZHJtX2F0b21pY19jb21taXQoc2F2ZWRfc3RhdGUpIHdyYXBwZWQgaW4gYSBX QVJOX09OIHRvIG1ha2Ugc3VyZSBpdAo+IGFsd2F5cyB3b3Jrcy4KV2VsbCwgZm9yICFmb3JjZV9y ZXN0b3JlIHdlIHdhbnQgdG8gZG8gYW4gaW5pdGlhbCBzYW5pdGl6aW5nIG1vZGVzZXQgdG9vLCBi dXQgd2l0aCB0aGUgZnVsbCBkaXNhYmxlZCBzdGF0ZSBhcyByZWZlcmVuY2UgcG9pbnQuCkknbSBu b3Qgc3VyZSBkdXBlIHN0YXRlIGZvbGxvd2VkIGJ5IGEgc3dhcCwgaXMgZGlmZmVyZW50IGZyb20g c2F2ZSBvbGQgc3RhdGUsIGFuZCByZWFkIG91dCB0byBjdXJyZW50IHN0YXRlLgo+IE9mYyB3ZSBz dGlsbCBuZWVkIHRoZSB3dy1tdXRleCBkZWFkbG9jayBhdm9pZGFuY2Ugd3JhcHBlZCBhcm91bmQg dGhpcywgYnV0Cj4gc2luY2UgYXRvbWljX2NvbW1pdCB3aWxsIGZpcnN0IGNvbXB1dGUgYWxsIGRl cml2ZWQgc3RhdGUgdGhlcmUncyBubyBuZWVkCj4gdG8gZHVwbGljYXRlIGFsbCB0aGUgaTkxNS1p bnRlcm5hbCBzdGF0ZSB0b28uIFRoYXQgc2hvdWxkIGFsbCB3b3JrIGxpa2UKPiB3aXRoIGFueSBv dGhlciBub3JtYWwgbW9kZXNldC4KTm8gbmVlZCB0byB3cmFwLCByZWFkb3V0IHRvdWNoZXMgZXZl cnl0aGluZyBzbyBsb2NrX2FsbCBpcyBmaW5lLgoKfk1hYXJ0ZW4KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK