From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: "Olivier Hainque" <hainque@adacore.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Ян Завадовский" <zavadovsky.yan@gmail.com>,
"Stefan Weil" <sw@weilnetz.de>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Fabien Chouteau" <chouteau@adacore.com>
Subject: Re: [Qemu-devel] [PATCH] thread-win32: fix GetThreadContext() permanently fails
Date: Tue, 23 Jun 2015 13:32:19 +0200 [thread overview]
Message-ID: <558943C3.9030709@redhat.com> (raw)
In-Reply-To: <20150623111822.GE30318@redhat.com>
On 23/06/2015 13:18, Daniel P. Berrange wrote:
> > For 2.5, however, I wonder if SuspendThread/ResumeThread is needed at
> > all now that cpu_exit doesn't have to undo block chaining anymore. Even
> > on POSIX platforms the signal might not be necessary anymore.
>
> If you don't have that signal / SuspendThread/ResumtThread requirement,
That was independent of QEMU reinventing the wheel for mutexes/condvars.
> might that enable QEMU to just depend on the winpthreads library that
> is provided by Mingw project, and not bother reinventing the wheel for
> thread library portabilty ?
We can and should just reuse glib these days as much as we can (probably
not entirely because glib doesn't have detached threads). At least a
few years ago, winpthreads was much slower than native Win32, which is
why everyone reinvents the wheel.
I was planning to do it in 2.5.
Paolo
next prev parent reply other threads:[~2015-06-23 11:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 21:54 [Qemu-devel] [PATCH] thread-win32: fix GetThreadContext() permanently fails Zavadovsky Yan
2015-06-23 6:02 ` Stefan Weil
2015-06-23 9:49 ` Fabien Chouteau
2015-06-23 10:11 ` Ян Завадовский
2015-06-23 9:55 ` Ян Завадовский
2015-06-23 10:30 ` Peter Maydell
2015-06-23 10:46 ` Paolo Bonzini
2015-06-23 11:18 ` Daniel P. Berrange
2015-06-23 11:32 ` Paolo Bonzini [this message]
2015-06-23 11:43 ` Daniel P. Berrange
2015-06-23 11:52 ` Paolo Bonzini
2015-06-23 11:23 ` Peter Maydell
2015-06-23 17:07 ` Stefan Weil
2015-06-24 9:09 ` Fabien Chouteau
2015-06-24 10:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558943C3.9030709@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=chouteau@adacore.com \
--cc=hainque@adacore.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=zavadovsky.yan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.