From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40290)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Z7Rft-0001WJ-JM
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 13:07:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Z7Rfq-0002nq-E2
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 13:07:53 -0400
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=39407
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Z7Rfq-0002nN-7s
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 13:07:50 -0400
Message-ID: <55899261.6020705@weilnetz.de>
Date: Tue, 23 Jun 2015 19:07:45 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1435010055-4584-1-git-send-email-zavadovsky.yan@gmail.com>
	<5588F689.8050202@weilnetz.de>
	<CAAkiskjHjmajpis+8U8pHRCo9SBo9s+zc58Cjk9=F31OcnKrow@mail.gmail.com>
	<CAFEAcA8s2Vbw=nKHU=U7kL2s_H=NoqNb6Ya5JxoeLX2w1SWw3g@mail.gmail.com>
	<55893923.9010304@redhat.com>
In-Reply-To: <55893923.9010304@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] thread-win32: fix GetThreadContext()
 permanently fails
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, =?UTF-8?B?0K/QvSDQl9Cw0LLQsNC00L7QstGB0LrQuNC5?= <zavadovsky.yan@gmail.com>, Fabien Chouteau <chouteau@adacore.com>
Cc: Olivier Hainque <hainque@adacore.com>, QEMU Developers <qemu-devel@nongnu.org>

Am 23.06.2015 um 12:46 schrieb Paolo Bonzini:
> On 23/06/2015 12:30, Peter Maydell wrote:
>> On 23 June 2015 at 10:55, =D0=AF=D0=BD =D0=97=D0=B0=D0=B2=D0=B0=D0=B4=D0=
=BE=D0=B2=D1=81=D0=BA=D0=B8=D0=B9 <zavadovsky.yan@gmail.com> wrote:
>>> On Tue, Jun 23, 2015 at 9:02 AM, Stefan Weil <sw@weilnetz.de> wrote:
>>>> We should add an URL to reliable documentation which supports that
>>>> claim.
>>> Unfortunately, MSDN says only "SuspendThread suspends the thread. It'=
s
>>> designed for debuggers. Don't use in applications.":
>>> https://msdn.microsoft.com/en-us/library/windows/desktop/ms686345(v=3D=
vs.85).aspx
>>> And nothing more useful.
>>> So when I found this piece of code with Suspend/Resume and failed Get=
Context
>>> I did some googling.
>>> And found this article:
>>> http://blogs.msdn.com/b/oldnewthing/archive/2015/02/05/10591215.aspx
>> Personally I am happy to treat a Raymond Chen blog post as "reliable
>> documentation"...
> Me too. :)

+1

Fabien, I wonder why nobody noticed that the current
code did not do what it was written for. As far as I see
the threads were created with the wrong options, so
GetThreadContext always failed and therefore was only
executed once, so there was no waiting for thread
suspension.

Removing the code would have given identical results.

Is that in an indicator that the SuspendThread is not
needed at all, as it was discussed in the other e-mails
here?

Stefan