All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Michal Privoznik <mprivozn@redhat.com>,  Thomas Huth <thuth@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Properly order build targets 'all' and 'check'
Date: Tue, 23 Jun 2015 20:29:57 +0300	[thread overview]
Message-ID: <55899795.8040609@msgid.tls.msk.ru> (raw)
In-Reply-To: <558960A3.5010509@redhat.com>

23.06.2015 16:35, Michal Privoznik wrote:
> On 23.06.2015 14:49, Thomas Huth wrote:

>> Maybe it's simpler to add the dependency into tests/Makefile instead?
>>
> 
> Yeah, that could work too. For some reason I thought that having it
> there would result in making 'all' just under tests/. But Now that I
> tried it out it works just nicely. Do you want me to post v2 or is that
> something that can be fixed just before pushing?

"Fixing" is not moving the new code to another file.  Please post a v2.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Michal Privoznik <mprivozn@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: Properly order build targets 'all' and 'check'
Date: Tue, 23 Jun 2015 20:29:57 +0300	[thread overview]
Message-ID: <55899795.8040609@msgid.tls.msk.ru> (raw)
In-Reply-To: <558960A3.5010509@redhat.com>

23.06.2015 16:35, Michal Privoznik wrote:
> On 23.06.2015 14:49, Thomas Huth wrote:

>> Maybe it's simpler to add the dependency into tests/Makefile instead?
>>
> 
> Yeah, that could work too. For some reason I thought that having it
> there would result in making 'all' just under tests/. But Now that I
> tried it out it works just nicely. Do you want me to post v2 or is that
> something that can be fixed just before pushing?

"Fixing" is not moving the new code to another file.  Please post a v2.

Thanks,

/mjt

  reply	other threads:[~2015-06-23 17:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 12:30 [Qemu-trivial] [PATCH] Makefile: Properly order build targets 'all' and 'check' Michal Privoznik
2015-06-23 12:30 ` [Qemu-devel] " Michal Privoznik
2015-06-23 12:37 ` [Qemu-trivial] " Peter Maydell
2015-06-23 12:37   ` Peter Maydell
2015-06-23 12:42   ` [Qemu-trivial] " Michal Privoznik
2015-06-23 12:42     ` Michal Privoznik
2015-06-23 12:49     ` [Qemu-trivial] " Thomas Huth
2015-06-23 12:49       ` Thomas Huth
2015-06-23 13:35       ` [Qemu-trivial] " Michal Privoznik
2015-06-23 13:35         ` Michal Privoznik
2015-06-23 17:29         ` Michael Tokarev [this message]
2015-06-23 17:29           ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2015-06-23 17:31         ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2015-06-23 17:31           ` Peter Maydell
2015-06-23 17:46           ` [Qemu-trivial] " Stefan Weil
2015-06-23 17:46             ` Stefan Weil
2015-06-25  7:08             ` [Qemu-trivial] " Markus Armbruster
2015-06-25  7:08               ` Markus Armbruster
2015-06-25  9:13               ` [Qemu-trivial] " Michal Privoznik
2015-06-25  9:13                 ` Michal Privoznik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55899795.8040609@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=mprivozn@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.