From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Z7S1O-0006Ec-I4 for mharc-qemu-trivial@gnu.org; Tue, 23 Jun 2015 13:30:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7S1M-00069T-7a for qemu-trivial@nongnu.org; Tue, 23 Jun 2015 13:30:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7S1L-0004uC-F9 for qemu-trivial@nongnu.org; Tue, 23 Jun 2015 13:30:04 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:42528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7S1G-0004ol-HW; Tue, 23 Jun 2015 13:29:58 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id C4C3C42051; Tue, 23 Jun 2015 20:29:57 +0300 (MSK) Message-ID: <55899795.8040609@msgid.tls.msk.ru> Date: Tue, 23 Jun 2015 20:29:57 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Michal Privoznik , Thomas Huth References: <58e7daaa2977c903b46c3b0dde64e81ce191b5d6.1435062620.git.mprivozn@redhat.com> <5589543B.1020309@redhat.com> <20150623144917.372248b1@thh440s> <558960A3.5010509@redhat.com> In-Reply-To: <558960A3.5010509@redhat.com> OpenPGP: id=804465C5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.62.121.231 Cc: QEMU Trivial , Peter Maydell , QEMU Developers Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Properly order build targets 'all' and 'check' X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2015 17:30:05 -0000 23.06.2015 16:35, Michal Privoznik wrote: > On 23.06.2015 14:49, Thomas Huth wrote: >> Maybe it's simpler to add the dependency into tests/Makefile instead? >> > > Yeah, that could work too. For some reason I thought that having it > there would result in making 'all' just under tests/. But Now that I > tried it out it works just nicely. Do you want me to post v2 or is that > something that can be fixed just before pushing? "Fixing" is not moving the new code to another file. Please post a v2. Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7S1K-00066a-FH for qemu-devel@nongnu.org; Tue, 23 Jun 2015 13:30:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7S1G-0004oq-Ow for qemu-devel@nongnu.org; Tue, 23 Jun 2015 13:30:02 -0400 Message-ID: <55899795.8040609@msgid.tls.msk.ru> Date: Tue, 23 Jun 2015 20:29:57 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <58e7daaa2977c903b46c3b0dde64e81ce191b5d6.1435062620.git.mprivozn@redhat.com> <5589543B.1020309@redhat.com> <20150623144917.372248b1@thh440s> <558960A3.5010509@redhat.com> In-Reply-To: <558960A3.5010509@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: Properly order build targets 'all' and 'check' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik , Thomas Huth Cc: QEMU Trivial , Peter Maydell , QEMU Developers 23.06.2015 16:35, Michal Privoznik wrote: > On 23.06.2015 14:49, Thomas Huth wrote: >> Maybe it's simpler to add the dependency into tests/Makefile instead? >> > > Yeah, that could work too. For some reason I thought that having it > there would result in making 'all' just under tests/. But Now that I > tried it out it works just nicely. Do you want me to post v2 or is that > something that can be fixed just before pushing? "Fixing" is not moving the new code to another file. Please post a v2. Thanks, /mjt