Re: [PATCH net-next V11 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Thomas F Herbert
	<thomasfherbert-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
	therbert-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH net-next V11 2/3] Check for vlan ethernet types for 8021.q or 802.1ad
Date: Tue, 23 Jun 2015 21:43:20 +0300	[thread overview]
Message-ID: <5589A8C8.6080702@cogentembedded.com> (raw)
In-Reply-To: <1435083990-12986-3-git-send-email-thomasfherbert-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hello.

On 06/23/2015 09:26 PM, Thomas F Herbert wrote:

> Signed-off-by: Thomas F Herbert <thomasfherbert@gmail.com>
[...]

> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
> index 920e445..3713454 100644
> --- a/include/linux/if_vlan.h
> +++ b/include/linux/if_vlan.h
> @@ -627,5 +627,14 @@ static inline netdev_features_t vlan_features_check(const struct sk_buff *skb,
>
>   	return features;
>   }
> +/**
> + * Check for legal valid vlan ether type.

    The comment doesn't follow the kernel-doc format determined by /**.

> + */
> +static inline bool eth_type_vlan(__be16 ethertype)
> +{
> +	if (ethertype == htons(ETH_P_8021Q) || ethertype == htons(ETH_P_8021AD))
> +		return true;
> +	return false;

    Perhaps *switch*?

[...]

WBR, Sergei

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev