From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 6/6] AMD-PVH: enable pvh if requirements met Date: Tue, 23 Jun 2015 22:34:10 -0400 Message-ID: <558A1722.9010907@oracle.com> References: <1434991058-6585-1-git-send-email-elena.ufimtseva@oracle.com> <1434991058-6585-7-git-send-email-elena.ufimtseva@oracle.com> <55896DA2020000780008849F@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55896DA2020000780008849F@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , elena.ufimtseva@oracle.com Cc: keir@xen.org, tim@xen.org, xen-devel@lists.xen.org, Aravind.Gopalakrishnan@amd.com, suravee.suthikulpanit@amd.com, Mukesh Rathor , roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On 06/23/2015 08:30 AM, Jan Beulich wrote: >>>> On 22.06.15 at 18:37, wrote: >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -1444,6 +1444,9 @@ const struct hvm_function_table * __init >> start_svm(void) >> svm_function_table.hap_capabilities = HVM_HAP_SUPERPAGE_2MB | >> ((cpuid_edx(0x80000001) & 0x04000000) ? HVM_HAP_SUPERPAGE_1GB : 0); >> >> + if ( cpu_has_svm_npt && cpu_has_svm_decode ) >> + svm_function_table.pvh_supported = 1; > If svm_decode indeed is a prereq, then the earlier patch dealing > with the handle_mmio() invocations doesn't need to fiddle with > VMEXIT_INVLPG other than to maybe add a documenting ASSERT(). > I am not sure we should require decode feature to be required for PVH support. I can't remember exactly but I think this feature was first introduced in family 15h so requiring it will leave at least family 10h processors as not supporting PVH. -boris