From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 6/9] x86/pvh: Properly set
 HYPERVISOR_COMPAT_VIRT_START for PVH guests
Date: Tue, 23 Jun 2015 22:55:53 -0400
Message-ID: <558A1C39.9090006@oracle.com>
References: <1434769773-5157-1-git-send-email-boris.ostrovsky@oracle.com>
	<1434769773-5157-7-git-send-email-boris.ostrovsky@oracle.com>
	<55897A70020000780008853A@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55897A70020000780008853A@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: elena.ufimtseva@oracle.com, Keir Fraser <keir@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, tim@xen.org, xen-devel@lists.xen.org, roger.pau@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 06/23/2015 09:25 AM, Jan Beulich wrote:
>>>> On 20.06.15 at 05:09, <boris.ostrovsky@oracle.com> wrote:
>> --- a/xen/arch/x86/domain.c
>> +++ b/xen/arch/x86/domain.c
>> @@ -584,7 +584,7 @@ int arch_domain_create(struct domain *d, unsigned int
>> domcr_flags,
>>       mapcache_domain_init(d);
>>   
>>       HYPERVISOR_COMPAT_VIRT_START(d) =
>> -        is_pv_domain(d) ? __HYPERVISOR_COMPAT_VIRT_START : ~0u;
>> +        is_hvm_domain(d) ? ~0u : __HYPERVISOR_COMPAT_VIRT_START;
> Why would a PVH domain be different in this respect from a HVM one?
>

No reason indeed. I somehow thought that layout should be similar to PV, 
which it doesn't need to be.

So this patch should be dropped.

-boris