From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 8/9] x86/pvh: Don't try to get l4 table for
 PVH guests in vcpu_destroy_pagetables()
Date: Tue, 23 Jun 2015 23:05:54 -0400
Message-ID: <558A1E92.1010702@oracle.com>
References: <1434769773-5157-1-git-send-email-boris.ostrovsky@oracle.com>
	<1434769773-5157-9-git-send-email-boris.ostrovsky@oracle.com>
	<55897D74020000780008858B@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55897D74020000780008858B@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: elena.ufimtseva@oracle.com, Keir Fraser <keir@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, tim@xen.org, xen-devel@lists.xen.org, roger.pau@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 06/23/2015 09:38 AM, Jan Beulich wrote:
>>>> On 20.06.15 at 05:09, <boris.ostrovsky@oracle.com> wrote:
>> --- a/xen/arch/x86/mm.c
>> +++ b/xen/arch/x86/mm.c
>> @@ -2652,7 +2652,7 @@ int vcpu_destroy_pagetables(struct vcpu *v)
>>       if ( rc )
>>           return rc;
>>   
>> -    if ( is_pv_32on64_vcpu(v) )
>> +    if ( is_pv_32on64_vcpu(v) && !is_pvh_vcpu(v) )
> This looks wrong - is_pv_32on64_vcpu() should imply is_pv_vcpu()
> and hence !is_pvh_vcpu().


That's because I kept
     d->arch.is_32bit_pv = d->arch.has_32bit_shinfo = 1;
in switch_compat() for both PV and PVH. I should probably only set 
has_32bit_shinfo for PVH.


-boris