From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41747)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z7hLA-0003g1-BQ
	for Qemu-devel@nongnu.org; Wed, 24 Jun 2015 05:51:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z7hL6-00020P-C1
	for Qemu-devel@nongnu.org; Wed, 24 Jun 2015 05:51:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z7hL6-000204-75
	for Qemu-devel@nongnu.org; Wed, 24 Jun 2015 05:51:28 -0400
Message-ID: <558A7D9B.8050306@redhat.com>
Date: Wed, 24 Jun 2015 11:51:23 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <D23DADB3-0154-4EBE-9966-7AF30083D819@livius.net>
	<803004FB-2F23-439C-AF59-E71FA7DDC2C4@livius.net>
	<55893750.3020502@suse.de>
	<BDDC6D0B-5CF3-4DA8-882B-C368F420C025@livius.net>
	<55896C57.6060904@suse.de>
	<CAEgOgz7VPX=Fefcx6VzoV5BapxH=NPXnRhdNTwFyNdz75w5W4g@mail.gmail.com>
	<5B7FDD61-18AF-4024-9254-7B96582540E9@livius.net>
	<5EDCF9DC-453A-435C-9379-DE250716BA0F@livius.net>
	<CAEgOgz7VKzUrRkpWYYjK1Z53iwTPA1ZAAiYfqgxaa13ABMYrXw@mail.gmail.com>
	<04BD2F65-DACC-4865-9C16-2936F84220FD@livius.net>
In-Reply-To: <04BD2F65-DACC-4865-9C16-2936F84220FD@livius.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] QDev explicit constructors & destructors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liviu Ionescu <ilg@livius.net>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>, QEMU Developers <Qemu-devel@nongnu.org>



On 24/06/2015 11:29, Liviu Ionescu wrote:
> ok, I managed to restructure my code to get rid of the explicit
> constructor. :-)
> 
> I also avoided properties aliases, and did prop setting in two steps,
> in machine init I set props in MCU, and from here I manually set them
> in specific peripherals, after they are created. less efficient then
> aliases, but functional.
> 
> however, there is one aspect that I'm not compliant with your
> requirements: I'm still creating objects in realize(), since many of
> my objects have dynamic content. for example MCUs have different
> number of GPIOs, it is possible to create all of them in init and
> then map only the used ones, but to me this looks sub-optimal.

I think this is okay.

Paolo