From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7k6P-0005tB-MN for qemu-devel@nongnu.org; Wed, 24 Jun 2015 08:48:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7k6L-0000jI-GF for qemu-devel@nongnu.org; Wed, 24 Jun 2015 08:48:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56954 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7k6L-0000jD-Ao for qemu-devel@nongnu.org; Wed, 24 Jun 2015 08:48:25 -0400 Message-ID: <558AA714.9060600@suse.de> Date: Wed, 24 Jun 2015 14:48:20 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <5571B77D.1070202@suse.de> <20150605150535.GJ3410@thinpad.lan.raisama.net> In-Reply-To: <20150605150535.GJ3410@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] cpus: Change exec_init arg to cpu, not env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Peter Maydell , Jia Liu , Peter Crosthwaite , Bastian Koppelmann , Anthony Green , Mark Cave-Ayland , qemu-devel@nongnu.org, Alexander Graf , Blue Swirl , Max Filippov , Peter Crosthwaite , Paolo Bonzini , Michael Walle , Bharata B Rao , "Edgar E. Iglesias" , Guan Xuetao , Leon Alrae , Aurelien Jarno , rth@twiddle.net Am 05.06.2015 um 17:05 schrieb Eduardo Habkost: > On Fri, Jun 05, 2015 at 11:51:41PM +0900, Andreas F=E4rber wrote: >> Am 25.05.2015 um 15:22 schrieb Peter Crosthwaite: >>> The callers (most of them in target-foo/cpu.c) to this function all >>> have the cpu pointer handy. Just pass it to avoid an ENV_GET_CPU from >>> core code (in exec.c). > [...] >> Reviewed-by: Andreas F=E4rber >> >> I assume this will conflict with another patch adding an Error** >> argument - Eduardo, please help coordinating this. >=20 > I asked Peter to rebase on top of Bharata's "Bitmap based CPU > enumeration" series (that's already on v3 and got some Reviewed-by > lines), but both Peter and Bharata need to know which tree those series > are expected to be included. I was expecting you to handle cpu_exec_init() through your x86 tree, but seems that didn't happen. I am going through CPU patches today, so could take open series but then would need to pick up the ENV_* stuff too, which I thought would go through Paolo in my absence... Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)