From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86: fix build with old gas
Date: Wed, 24 Jun 2015 14:08:35 +0100 [thread overview]
Message-ID: <558AABD3.6030806@citrix.com> (raw)
In-Reply-To: <558AC5320200007800088E61@mail.emea.novell.com>
On 24/06/15 13:56, Jan Beulich wrote:
> .string8 is only supported by gas 2.19 and newer.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/include/asm-x86/bug.h
> +++ b/xen/include/asm-x86/bug.h
> @@ -79,7 +79,7 @@ extern const struct bug_frame __start_bu
> .L\@ud: ud2a
>
> .pushsection .rodata.str1, "aMS", @progbits, 1
> - .L\@s1: .string8 "\file_str"
> + .L\@s1: .asciz "\file_str"
> .popsection
>
> .pushsection .bug_frames.\type, "a", @progbits
> @@ -91,7 +91,7 @@ extern const struct bug_frame __start_bu
>
> .if \second_frame
> .pushsection .rodata.str1, "aMS", @progbits, 1
> - .L\@s2: .string8 "\msg"
> + .L\@s2: .asciz "\msg"
> .popsection
> .long 0, (.L\@s2 - .L\@bf)
> .endif
>
>
>
prev parent reply other threads:[~2015-06-24 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 12:56 [PATCH] x86: fix build with old gas Jan Beulich
2015-06-24 13:08 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558AABD3.6030806@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.