* [PATCH] x86: fix build with old gas
@ 2015-06-24 12:56 Jan Beulich
2015-06-24 13:08 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2015-06-24 12:56 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Keir Fraser
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
.string8 is only supported by gas 2.19 and newer.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/asm-x86/bug.h
+++ b/xen/include/asm-x86/bug.h
@@ -79,7 +79,7 @@ extern const struct bug_frame __start_bu
.L\@ud: ud2a
.pushsection .rodata.str1, "aMS", @progbits, 1
- .L\@s1: .string8 "\file_str"
+ .L\@s1: .asciz "\file_str"
.popsection
.pushsection .bug_frames.\type, "a", @progbits
@@ -91,7 +91,7 @@ extern const struct bug_frame __start_bu
.if \second_frame
.pushsection .rodata.str1, "aMS", @progbits, 1
- .L\@s2: .string8 "\msg"
+ .L\@s2: .asciz "\msg"
.popsection
.long 0, (.L\@s2 - .L\@bf)
.endif
[-- Attachment #2: x86-asm-assert-use-asciz.patch --]
[-- Type: text/plain, Size: 805 bytes --]
x86: fix build with old gas
.string8 is only supported by gas 2.19 and newer.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/asm-x86/bug.h
+++ b/xen/include/asm-x86/bug.h
@@ -79,7 +79,7 @@ extern const struct bug_frame __start_bu
.L\@ud: ud2a
.pushsection .rodata.str1, "aMS", @progbits, 1
- .L\@s1: .string8 "\file_str"
+ .L\@s1: .asciz "\file_str"
.popsection
.pushsection .bug_frames.\type, "a", @progbits
@@ -91,7 +91,7 @@ extern const struct bug_frame __start_bu
.if \second_frame
.pushsection .rodata.str1, "aMS", @progbits, 1
- .L\@s2: .string8 "\msg"
+ .L\@s2: .asciz "\msg"
.popsection
.long 0, (.L\@s2 - .L\@bf)
.endif
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: fix build with old gas
2015-06-24 12:56 [PATCH] x86: fix build with old gas Jan Beulich
@ 2015-06-24 13:08 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2015-06-24 13:08 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Keir Fraser
On 24/06/15 13:56, Jan Beulich wrote:
> .string8 is only supported by gas 2.19 and newer.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/include/asm-x86/bug.h
> +++ b/xen/include/asm-x86/bug.h
> @@ -79,7 +79,7 @@ extern const struct bug_frame __start_bu
> .L\@ud: ud2a
>
> .pushsection .rodata.str1, "aMS", @progbits, 1
> - .L\@s1: .string8 "\file_str"
> + .L\@s1: .asciz "\file_str"
> .popsection
>
> .pushsection .bug_frames.\type, "a", @progbits
> @@ -91,7 +91,7 @@ extern const struct bug_frame __start_bu
>
> .if \second_frame
> .pushsection .rodata.str1, "aMS", @progbits, 1
> - .L\@s2: .string8 "\msg"
> + .L\@s2: .asciz "\msg"
> .popsection
> .long 0, (.L\@s2 - .L\@bf)
> .endif
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-24 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-24 12:56 [PATCH] x86: fix build with old gas Jan Beulich
2015-06-24 13:08 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.