From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86: fix build with old gas
Date: Wed, 24 Jun 2015 14:08:35 +0100
Message-ID: <558AABD3.6030806@citrix.com>
References: <558AC5320200007800088E61@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=610b37477=Andrew.Cooper3@citrix.com>)
	id 1Z7kXp-0001fT-JU
	for xen-devel@lists.xenproject.org; Wed, 24 Jun 2015 13:16:49 +0000
In-Reply-To: <558AC5320200007800088E61@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 24/06/15 13:56, Jan Beulich wrote:
> .string8 is only supported by gas 2.19 and newer.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/include/asm-x86/bug.h
> +++ b/xen/include/asm-x86/bug.h
> @@ -79,7 +79,7 @@ extern const struct bug_frame __start_bu
>      .L\@ud: ud2a
>  
>      .pushsection .rodata.str1, "aMS", @progbits, 1
> -         .L\@s1: .string8 "\file_str"
> +         .L\@s1: .asciz "\file_str"
>      .popsection
>  
>      .pushsection .bug_frames.\type, "a", @progbits
> @@ -91,7 +91,7 @@ extern const struct bug_frame __start_bu
>  
>          .if \second_frame
>              .pushsection .rodata.str1, "aMS", @progbits, 1
> -                .L\@s2: .string8 "\msg"
> +                .L\@s2: .asciz "\msg"
>              .popsection
>              .long 0, (.L\@s2 - .L\@bf)
>          .endif
>
>
>