From: "Andreas Färber" <afaerber@suse.de>
To: Liviu Ionescu <ilg@livius.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
QEMU Developers <Qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC] QDev explicit constructors & destructors
Date: Wed, 24 Jun 2015 16:18:39 +0200 [thread overview]
Message-ID: <558ABC3F.90002@suse.de> (raw)
In-Reply-To: <3C3A3D3D-F576-43A9-B1A8-1D4D27CF315B@livius.net>
Am 24.06.2015 um 16:11 schrieb Liviu Ionescu:
> On 24 Jun 2015, at 16:50, Andreas Färber <afaerber@suse.de> wrote:
>
>> You're still doing the {...} thing I asked you not to do.
>
> thank you for your suggestions.
It's not a suggestion. Our Coding Style is a mandatory requirement for
code review. I already pointed out that it affects readability for those
accustomed to our Coding Style. Instead of you arguing over it I
expected you to acknowledge it and to adapt your code.
> right now I'm more concerned on which APIs to use, and my current understanding is that you prefer direct QOM calls over QDev, which are deprecated. is this correct?
>
> regarding the layout of my code, I did not make a final decision yet, but it might very well be C++, with some wrappers over your QOM objects.
First, they're not "my" QOM objects. I did not invent it.
Second, we are certainly not going to let every contributor, especially
not new ones, make their own choices of programming language inside our
code base. QOM was not just a transitory tool, some people here (not me)
were and are against C++, which currently is optional for AArch64
disassembler.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-06-24 14:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 10:48 [Qemu-devel] [RFC] QDev explicit constructors & destructors Liviu Ionescu
2015-06-15 11:13 ` Liviu Ionescu
2015-06-15 13:35 ` Liviu Ionescu
2015-06-22 20:48 ` Liviu Ionescu
2015-06-23 7:47 ` Markus Armbruster
2015-06-23 9:12 ` Liviu Ionescu
2015-06-23 10:39 ` Andreas Färber
2015-06-23 12:58 ` Liviu Ionescu
2015-06-23 14:25 ` Andreas Färber
2015-06-23 16:15 ` Liviu Ionescu
2015-06-23 18:31 ` Peter Crosthwaite
2015-06-23 19:10 ` Liviu Ionescu
2015-06-23 20:57 ` Peter Crosthwaite
2015-06-23 21:24 ` Liviu Ionescu
2015-06-23 19:27 ` Andreas Färber
2015-06-23 20:10 ` Liviu Ionescu
2015-06-24 7:30 ` Liviu Ionescu
2015-06-24 8:29 ` Peter Crosthwaite
2015-06-24 9:29 ` Liviu Ionescu
2015-06-24 9:51 ` Paolo Bonzini
2015-06-24 13:41 ` Andreas Färber
2015-06-24 13:50 ` Andreas Färber
2015-06-24 14:11 ` Liviu Ionescu
2015-06-24 14:18 ` Andreas Färber [this message]
2015-06-24 14:39 ` Liviu Ionescu
2015-06-24 14:41 ` Andreas Färber
2015-06-24 20:14 ` Liviu Ionescu
2015-06-24 8:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558ABC3F.90002@suse.de \
--to=afaerber@suse.de \
--cc=Qemu-devel@nongnu.org \
--cc=ilg@livius.net \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.