From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source Date: Wed, 24 Jun 2015 11:07:13 -0500 Message-ID: <558AD5B1.8030406@ti.com> References: <1435076114-12416-1-git-send-email-nm@ti.com> <1435076114-12416-5-git-send-email-nm@ti.com> <558ACE87.6040509@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <558ACE87.6040509@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Grygorii Strashko , Alexandre Belloni , Alessandro Zummo Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, balbi@ti.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com List-Id: linux-omap@vger.kernel.org On 06/24/2015 10:36 AM, Grygorii Strashko wrote: > On 06/23/2015 07:15 PM, Nishanth Menon wrote: [...] >> + ds1307->wakeirq = of_irq_get(node, 1); >> + if (ds1307->wakeirq <= 0) { >> + if (ds1307->wakeirq == -EPROBE_DEFER) { >> + err = ds1307->wakeirq; >> + goto exit; >> + } >> + ds1307->wakeirq = 0; >> + goto no_irq; >> + } > > Might be above code could be done a little bit simpler? > > err = of_irq_get(node, 1); > if (err <= 0) { > if (err == -EPROBE_DEFER) > goto exit; > goto no_irq; I had considered it, but problem with this approach is that is err does not get reset back to 0 and probe will fail as it flows through the rest of the code.. which is not our intent. > } > ds1307->wakeirq = err; > -- Regards, Nishanth Menon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bear.ext.ti.com (bear.ext.ti.com. [192.94.94.41]) by gmr-mx.google.com with ESMTPS id f17si220781igt.0.2015.06.24.09.07.21 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 24 Jun 2015 09:07:21 -0700 (PDT) Message-ID: <558AD5B1.8030406@ti.com> Date: Wed, 24 Jun 2015 11:07:13 -0500 From: Nishanth Menon MIME-Version: 1.0 To: Grygorii Strashko , Alexandre Belloni , Alessandro Zummo CC: , , , , Subject: [rtc-linux] Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source References: <1435076114-12416-1-git-send-email-nm@ti.com> <1435076114-12416-5-git-send-email-nm@ti.com> <558ACE87.6040509@ti.com> In-Reply-To: <558ACE87.6040509@ti.com> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 06/24/2015 10:36 AM, Grygorii Strashko wrote: > On 06/23/2015 07:15 PM, Nishanth Menon wrote: [...] >> + ds1307->wakeirq = of_irq_get(node, 1); >> + if (ds1307->wakeirq <= 0) { >> + if (ds1307->wakeirq == -EPROBE_DEFER) { >> + err = ds1307->wakeirq; >> + goto exit; >> + } >> + ds1307->wakeirq = 0; >> + goto no_irq; >> + } > > Might be above code could be done a little bit simpler? > > err = of_irq_get(node, 1); > if (err <= 0) { > if (err == -EPROBE_DEFER) > goto exit; > goto no_irq; I had considered it, but problem with this approach is that is err does not get reset back to 0 and probe will fail as it flows through the rest of the code.. which is not our intent. > } > ds1307->wakeirq = err; > -- Regards, Nishanth Menon -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: nm@ti.com (Nishanth Menon) Date: Wed, 24 Jun 2015 11:07:13 -0500 Subject: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source In-Reply-To: <558ACE87.6040509@ti.com> References: <1435076114-12416-1-git-send-email-nm@ti.com> <1435076114-12416-5-git-send-email-nm@ti.com> <558ACE87.6040509@ti.com> Message-ID: <558AD5B1.8030406@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/24/2015 10:36 AM, Grygorii Strashko wrote: > On 06/23/2015 07:15 PM, Nishanth Menon wrote: [...] >> + ds1307->wakeirq = of_irq_get(node, 1); >> + if (ds1307->wakeirq <= 0) { >> + if (ds1307->wakeirq == -EPROBE_DEFER) { >> + err = ds1307->wakeirq; >> + goto exit; >> + } >> + ds1307->wakeirq = 0; >> + goto no_irq; >> + } > > Might be above code could be done a little bit simpler? > > err = of_irq_get(node, 1); > if (err <= 0) { > if (err == -EPROBE_DEFER) > goto exit; > goto no_irq; I had considered it, but problem with this approach is that is err does not get reset back to 0 and probe will fail as it flows through the rest of the code.. which is not our intent. > } > ds1307->wakeirq = err; > -- Regards, Nishanth Menon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753063AbbFXQIS (ORCPT ); Wed, 24 Jun 2015 12:08:18 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:33163 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbbFXQIK (ORCPT ); Wed, 24 Jun 2015 12:08:10 -0400 Message-ID: <558AD5B1.8030406@ti.com> Date: Wed, 24 Jun 2015 11:07:13 -0500 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Grygorii Strashko , Alexandre Belloni , Alessandro Zummo CC: , , , , Subject: Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source References: <1435076114-12416-1-git-send-email-nm@ti.com> <1435076114-12416-5-git-send-email-nm@ti.com> <558ACE87.6040509@ti.com> In-Reply-To: <558ACE87.6040509@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/24/2015 10:36 AM, Grygorii Strashko wrote: > On 06/23/2015 07:15 PM, Nishanth Menon wrote: [...] >> + ds1307->wakeirq = of_irq_get(node, 1); >> + if (ds1307->wakeirq <= 0) { >> + if (ds1307->wakeirq == -EPROBE_DEFER) { >> + err = ds1307->wakeirq; >> + goto exit; >> + } >> + ds1307->wakeirq = 0; >> + goto no_irq; >> + } > > Might be above code could be done a little bit simpler? > > err = of_irq_get(node, 1); > if (err <= 0) { > if (err == -EPROBE_DEFER) > goto exit; > goto no_irq; I had considered it, but problem with this approach is that is err does not get reset back to 0 and probe will fail as it flows through the rest of the code.. which is not our intent. > } > ds1307->wakeirq = err; > -- Regards, Nishanth Menon