All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Don't export VERBOSE unless V=1 (for CMake)
Date: Wed, 24 Jun 2015 23:49:08 +0200	[thread overview]
Message-ID: <558B25D4.3050105@mind.be> (raw)
In-Reply-To: <1435095367-4223-1-git-send-email-cedric.marie@openmailbox.org>

On 06/23/15 23:36, C?dric Marie wrote:
> CMake verbose mode is based on VERBOSE environment variable.
> * If VERBOSE is exported but empty, only "Dependee ... is newer than
> depender ..." messages are shown.
> * If VERBOSE is exported and set (whatever the value), all compilation
> commands are shown.
> 
> VERBOSE is currently systematically exported by Buildroot, even if it
> is empty, in the root Makefile, which implies that the "light" verbose
> mode - with "Dependee ... is newer than depender ..." messages - is
> always enabled.
> 
> VERBOSE should only be exported when V=1, which is the standard way to
> enable verbose mode in Buildroot.
> 
> Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> ---
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index d3f80c4..8eb21d4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -215,6 +215,7 @@ ifeq ($(KBUILD_VERBOSE),1)
>  ifndef VERBOSE
>    VERBOSE = 1
>  endif
> +export VERBOSE
>  else
>    quiet = quiet_
>    Q = @
> @@ -228,7 +229,7 @@ SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
>  # kconfig uses CONFIG_SHELL
>  CONFIG_SHELL := $(SHELL)
>  
> -export SHELL CONFIG_SHELL quiet Q KBUILD_VERBOSE VERBOSE
> +export SHELL CONFIG_SHELL quiet Q KBUILD_VERBOSE
>  
>  ifndef HOSTAR
>  HOSTAR := ar
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2015-06-24 21:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 21:36 [Buildroot] [PATCH] Don't export VERBOSE unless V=1 (for CMake) Cédric Marie
2015-06-24 21:49 ` Arnout Vandecappelle [this message]
2015-06-24 22:49 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558B25D4.3050105@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.