Re: [PATCH] drm/i915: Also perform gpu reset under execlist mode.

From: Zhi Wang <zhi.a.wang@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	"Niu, Bing" <bing.niu@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Also perform gpu reset under execlist mode.
Date: Thu, 25 Jun 2015 05:56:58 +0800	[thread overview]
Message-ID: <558B27AA.9020404@intel.com> (raw)
In-Reply-To: <20150625123716.GK30757@nuc-i3427.alporthouse.com>

Hi Chris:
     Thanks for the reply! I just dig the code. It looks there is no 
special code path for execlist shutdown. It has init_rings(), but 
doesn't have cleanup_rings(), only clean_ring(), which are called for 
each ring one by one when i915_gem_cleanup_ringbuffer() gets called.

Do you have any advice? :)

Thanks,
Zhi.

于 06/25/15 20:37, Chris Wilson 写道:
> On Thu, Jun 25, 2015 at 12:24:59PM +0000, Wang, Zhi A wrote:
>> Hi Chris:
>>      Thanks for the comments that extends our knowledge about this modification. Really appreciate the help. But is it possible that we still need an ordinary gpu reset here? Consider that we may modprobe i915 with i915.enable_execlists=1 then unload it, then modprobe i915.enable_execlists=0, according to bspec, changing execlist mode to ringbuffer mode, a hardware reset is needed?
>
> Sounds credible that execlist -> execbuffer requires a reset. That reset
> should be called in execlist shutdown and documented appropriately.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx