From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Thu, 25 Jun 2015 15:05:34 +0900 Subject: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method In-Reply-To: <558B984D.9040309@linaro.org> References: <1435137673-1629-1-git-send-email-vaibhav.hiremath@linaro.org> <1435137673-1629-3-git-send-email-vaibhav.hiremath@linaro.org> <558B90F7.80700@linaro.org> <558B9272.6090100@samsung.com> <558B9549.5010705@linaro.org> <558B96B7.3030501@samsung.com> <558B984D.9040309@linaro.org> Message-ID: <558B9A2E.4020009@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 25.06.2015 14:57, Vaibhav Hiremath wrote: > > > On Thursday 25 June 2015 11:20 AM, Krzysztof Kozlowski wrote: >> On 25.06.2015 14:44, Vaibhav Hiremath wrote: >>> >>> >>> On Thursday 25 June 2015 11:02 AM, Krzysztof Kozlowski wrote: >>>> On 25.06.2015 14:26, Vaibhav Hiremath wrote: >>>>> >>>>> >>>>> On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: >>>>>> 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath >>>>>> : >>>>>>> As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe >>>>>>> (page 0) controls the method of clearing interrupt >>>>>>> status of 88pm800 family of devices; >>>>>>> >>>>>>> 0: clear on read >>>>>>> 1: clear on write >>>>>>> >>>>>>> This patch allows to configure this field, through DT. >>>>>>> >>>>>>> Also, as suggested by "Lee Jones" renaming DT property and variable >>>>>>> field to appropriate name. >>>>>>> >>>>>>> Signed-off-by: Zhao Ye >>>>>>> Signed-off-by: Vaibhav Hiremath >>>>>> >>>> > > > >>> >>> Yes, >>> Fair enough... >>> >>> I see very little value in runtime configuration, why not just do it >>> only way (either read or write)? >>> I would prefer to just set it by default (during init), to clear irq on >>> write. >> >> Hard-coding a default value, if board files are not present, looks OK >> to me. >> > > This is how it will look, I will also update the binding information > with this. > > > hvaibhav at hvaibhav-ThinkPad-T440p:~/projects/mainline/linux$ git diff > --cached > diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c > index 0a417ac..e415a06 100644 > --- a/drivers/mfd/88pm800.c > +++ b/drivers/mfd/88pm800.c > @@ -645,9 +645,8 @@ static int pm800_probe(struct i2c_client *client, > dev_err(&client->dev, "failed to allocaate > memory\n"); > return -ENOMEM; > } > - > - pdata->irq_clr_on_wr = of_property_read_bool(np, > - "marvell,irq-clr-on-write"); > + /* Setting irq clear method on write */ > + pdata->irq_clr_on_wr = true; > } > > ret = pm80x_init(client); IMHO it is good. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method Date: Thu, 25 Jun 2015 15:05:34 +0900 Message-ID: <558B9A2E.4020009@samsung.com> References: <1435137673-1629-1-git-send-email-vaibhav.hiremath@linaro.org> <1435137673-1629-3-git-send-email-vaibhav.hiremath@linaro.org> <558B90F7.80700@linaro.org> <558B9272.6090100@samsung.com> <558B9549.5010705@linaro.org> <558B96B7.3030501@samsung.com> <558B984D.9040309@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <558B984D.9040309@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, Zhao Ye , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lee.jones@linaro.org List-Id: devicetree@vger.kernel.org On 25.06.2015 14:57, Vaibhav Hiremath wrote: > > > On Thursday 25 June 2015 11:20 AM, Krzysztof Kozlowski wrote: >> On 25.06.2015 14:44, Vaibhav Hiremath wrote: >>> >>> >>> On Thursday 25 June 2015 11:02 AM, Krzysztof Kozlowski wrote: >>>> On 25.06.2015 14:26, Vaibhav Hiremath wrote: >>>>> >>>>> >>>>> On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: >>>>>> 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath >>>>>> : >>>>>>> As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe >>>>>>> (page 0) controls the method of clearing interrupt >>>>>>> status of 88pm800 family of devices; >>>>>>> >>>>>>> 0: clear on read >>>>>>> 1: clear on write >>>>>>> >>>>>>> This patch allows to configure this field, through DT. >>>>>>> >>>>>>> Also, as suggested by "Lee Jones" renaming DT property and variable >>>>>>> field to appropriate name. >>>>>>> >>>>>>> Signed-off-by: Zhao Ye >>>>>>> Signed-off-by: Vaibhav Hiremath >>>>>> >>>> > > > >>> >>> Yes, >>> Fair enough... >>> >>> I see very little value in runtime configuration, why not just do it >>> only way (either read or write)? >>> I would prefer to just set it by default (during init), to clear irq on >>> write. >> >> Hard-coding a default value, if board files are not present, looks OK >> to me. >> > > This is how it will look, I will also update the binding information > with this. > > > hvaibhav@hvaibhav-ThinkPad-T440p:~/projects/mainline/linux$ git diff > --cached > diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c > index 0a417ac..e415a06 100644 > --- a/drivers/mfd/88pm800.c > +++ b/drivers/mfd/88pm800.c > @@ -645,9 +645,8 @@ static int pm800_probe(struct i2c_client *client, > dev_err(&client->dev, "failed to allocaate > memory\n"); > return -ENOMEM; > } > - > - pdata->irq_clr_on_wr = of_property_read_bool(np, > - "marvell,irq-clr-on-write"); > + /* Setting irq clear method on write */ > + pdata->irq_clr_on_wr = true; > } > > ret = pm80x_init(client); IMHO it is good. Best regards, Krzysztof