From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.s-osg.org ([54.187.51.154]:49804 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbFYH3T (ORCPT ); Thu, 25 Jun 2015 03:29:19 -0400 Message-ID: <558BADCC.6000800@osg.samsung.com> Date: Thu, 25 Jun 2015 09:29:16 +0200 From: Stefan Schmidt MIME-Version: 1.0 Subject: Re: [PATCH bluetooth-next] mac802154: rename seq to sequence_number References: <1435213871-2450-1-git-send-email-varkab@cdac.in> In-Reply-To: <1435213871-2450-1-git-send-email-varkab@cdac.in> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Varka Bhadram , linux-wpan@vger.kernel.org Cc: alex.aring@gmail.com, Varka Bhadram Hello. On 25/06/15 08:31, Varka Bhadram wrote: > This patch rename ieee802154_hdr member seq to sequence_number. Any good reason for this? I think seq is quite clear in this context and making it sequence_number has no real benefit. If others disagree I'm fine to let that one in though. No hard feelings about it. regards Stefan Schmidt > Signed-off-by: Varka Bhadram > --- > include/net/ieee802154_netdev.h | 2 +- > net/ieee802154/header_ops.c | 2 +- > net/mac802154/iface.c | 2 +- > net/mac802154/rx.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/net/ieee802154_netdev.h b/include/net/ieee802154_netdev.h > index 2c10a9f..9c95a74 100644 > --- a/include/net/ieee802154_netdev.h > +++ b/include/net/ieee802154_netdev.h > @@ -88,7 +88,7 @@ struct ieee802154_hdr_fc { > > struct ieee802154_hdr { > struct ieee802154_hdr_fc fc; > - u8 seq; > + u8 sequence_number; > struct ieee802154_addr source; > struct ieee802154_addr dest; > struct ieee802154_sechdr sec; > diff --git a/net/ieee802154/header_ops.c b/net/ieee802154/header_ops.c > index a051b69..9c3291b 100644 > --- a/net/ieee802154/header_ops.c > +++ b/net/ieee802154/header_ops.c > @@ -90,7 +90,7 @@ ieee802154_hdr_push(struct sk_buff *skb, const struct ieee802154_hdr *hdr) > int rc; > struct ieee802154_hdr_fc fc = hdr->fc; > > - buf[pos++] = hdr->seq; > + buf[pos++] = hdr->sequence_number; > > fc.dest_addr_mode = hdr->dest.mode; > > diff --git a/net/mac802154/iface.c b/net/mac802154/iface.c > index 416de90..0bc0f44 100644 > --- a/net/mac802154/iface.c > +++ b/net/mac802154/iface.c > @@ -372,7 +372,7 @@ static int mac802154_header_create(struct sk_buff *skb, > hdr.fc.type = cb->type; > hdr.fc.security_enabled = cb->secen; > hdr.fc.ack_request = cb->ackreq; > - hdr.seq = atomic_inc_return(&dev->ieee802154_ptr->dsn) & 0xFF; > + hdr.sequence_number = atomic_inc_return(&dev->ieee802154_ptr->dsn) & 0xFF; > > if (mac802154_set_header_security(sdata, &hdr, cb) < 0) > return -EINVAL; > diff --git a/net/mac802154/rx.c b/net/mac802154/rx.c > index 5a258c1..48781a6 100644 > --- a/net/mac802154/rx.c > +++ b/net/mac802154/rx.c > @@ -142,7 +142,7 @@ ieee802154_parse_frame_start(struct sk_buff *skb, struct ieee802154_hdr *hdr) > skb->mac_len = hlen; > > pr_debug("fc: %04x dsn: %02x\n", le16_to_cpup((__le16 *)&hdr->fc), > - hdr->seq); > + hdr->sequence_number); > > cb->type = hdr->fc.type; > cb->ackreq = hdr->fc.ack_request;