From: Renaud Barbier <renaud.barbier@ge.com>
To: barebox@lists.infradead.org
Subject: Re: [RFC V2 1/3] common: move DDR_SPD to common/Kconfig
Date: Thu, 25 Jun 2015 10:32:00 +0100 [thread overview]
Message-ID: <558BCA90.2050105@ge.com> (raw)
In-Reply-To: <1435150649-10266-2-git-send-email-alllecs@yandex.ru>
There may be an issue in the future. DDR_SPD selects the PPC Freescale
DDR driver support (my fault for this bad choice). If somebody was to
add and build a PPC machine with DDR support that is none of the
Freescale boards then the Freescale DDR driver will be selected too.
To be safe, something like that could be used:
diff --git a/arch/ppc/mach-mpc85xx/Makefile b/arch/ppc/mach-mpc85xx/Makefile
index 3e64617..a7453f7 100644
--- a/arch/ppc/mach-mpc85xx/Makefile
+++ b/arch/ppc/mach-mpc85xx/Makefile
@@ -9,5 +9,6 @@ obj-y += fsl_i2c.o
obj-$(CONFIG_MP) += mp.o
obj-$(CONFIG_OFTREE) += fdt.o
obj-$(CONFIG_DRIVER_NET_GIANFAR) += eth-devices.o
-obj-$(CONFIG_DDR_SPD) += ../ddr-8xxx/
+obj-$(CONFIG_FSL_DDR2) += ../ddr-8xxx/
+obj-$(CONFIG_FSL_DDR3) += ../ddr-8xxx/
On 24/06/2015 13:57, Alexander Smirnov wrote:
> This patch makes it possible to use ddr_spd-related
> routines in any arch not only in ppc.
>
> Signed-off-by: Alexander Smirnov <alllecs@yandex.ru>
> ---
> arch/ppc/mach-mpc85xx/Kconfig | 4 ----
> common/Kconfig | 4 ++++
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/ppc/mach-mpc85xx/Kconfig b/arch/ppc/mach-mpc85xx/Kconfig
> index e29be9c..aa518b9 100644
> --- a/arch/ppc/mach-mpc85xx/Kconfig
> +++ b/arch/ppc/mach-mpc85xx/Kconfig
> @@ -81,10 +81,6 @@ config P1022
> config MPC8544
> bool
>
> -config DDR_SPD
> - bool
> - select CRC16
> -
> config FSL_DDR2
> bool
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 925fe4b..91e4ef3 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -941,3 +941,7 @@ endmenu
>
> config HAS_DEBUG_LL
> bool
> +
> +config DDR_SPD
> + bool
> + select CRC16
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-06-25 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 12:57 [RFC V2 0/3] add decode command (SPD EEPROM data decoder) Alexander Smirnov
2015-06-24 12:57 ` [RFC V2 1/3] common: move DDR_SPD to common/Kconfig Alexander Smirnov
2015-06-25 9:32 ` Renaud Barbier [this message]
2015-06-24 12:57 ` [RFC V2 2/3] ddr_spd: add routune for printing SPD contents in human readable format Alexander Smirnov
2015-06-25 6:32 ` Sascha Hauer
2015-06-24 12:57 ` [RFC V2 3/3] add decode command (SPD EEPROM data decoder) Alexander Smirnov
2015-06-24 16:50 ` Antony Pavlov
2015-06-25 6:35 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558BCA90.2050105@ge.com \
--to=renaud.barbier@ge.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.