Re: [Qemu-devel] [PATCH 0/3] update CMOS for ISA-FDC with iobase=0x3f0

[Laszlo Ersek <lersek@redhat.com>]

On 06/25/15 09:55, Markus Armbruster wrote:
> Laszlo Ersek <lersek@redhat.com> writes:
> 
>> This is (again) for the other pc-q35-2.4 ISA-FDC problem reported by
>> Jan. Addressing comments from Markus.
>>
>> Jan, can you give it another try please? I realize this is getting old
>> pretty quick, so don't bother if you don't want to.
>>
>> Cc: Jan Tomko <jtomko@redhat.com>
>> Cc: John Snow <jsnow@redhat.com>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (3):
>>   hw/i386/pc: factor out pc_cmos_init_floppy()
>>   hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS
>>   hw/i386/pc: don't carry FDC from pc_basic_device_init() to
>>     pc_cmos_init()
>>
>>  include/hw/i386/pc.h |   3 +-
>>  hw/i386/pc.c         | 129 ++++++++++++++++++++++++++++++++++++++-------------
>>  hw/i386/pc_piix.c    |   5 +-
>>  hw/i386/pc_q35.c     |   5 +-
>>  4 files changed, 101 insertions(+), 41 deletions(-)
> 
> Matter-of-taste comments on PATCH 3.  Regardless:
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 

Thanks! I'll try to submit a new version soon, with John's and your R-b
added, in order to address your patch 3 remarks.

Thanks for your reviews.
Laszlo