From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v4 13/17] x86/hvm: remove HVMIO_dispatched
	I/O state
Date: Thu, 25 Jun 2015 13:29:49 +0100
Message-ID: <558BF43D.7010108@citrix.com>
References: <1435145089-21999-1-git-send-email-paul.durrant@citrix.com>
	<1435145089-21999-14-git-send-email-paul.durrant@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6114ee934=Andrew.Cooper3@citrix.com>)
	id 1Z86Hy-0003Cf-Od
	for xen-devel@lists.xenproject.org; Thu, 25 Jun 2015 12:29:54 +0000
In-Reply-To: <1435145089-21999-14-git-send-email-paul.durrant@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Paul Durrant <paul.durrant@citrix.com>, xen-devel@lists.xenproject.org
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 24/06/15 12:24, Paul Durrant wrote:
> +#define HVMIO_NEED_COMPLETION(_vio) \
> +    ( ((_vio)->io_state == HVMIO_awaiting_completion) &&    \
> +      !(_vio)->io_data_is_addr && \
> +      ((_vio)->io_dir == IOREQ_READ) )

Please can this be a static inline which takes a const pointer.

~Andrew