From: Arjan van de Ven <arjan@linux.intel.com>
To: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Cc: Ruchi Kandoi <kandoiruchi@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Oren Laadan <orenl@cellrox.com>, Micha Kalfon <micha@cellrox.com>,
Rom Lemarchand <romlem@android.com>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [RFC][PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread.
Date: Thu, 25 Jun 2015 18:21:46 -0700 [thread overview]
Message-ID: <558CA92A.50707@linux.intel.com> (raw)
In-Reply-To: <1435274682-9425-1-git-send-email-john.stultz@linaro.org>
On 6/25/2015 4:24 PM, John Stultz wrote:
> From: Ruchi Kandoi <kandoiruchi@google.com>
>
> This patch has been in the Android tree for ahwile, and I've not
> seen it posted for review. Unfortunately the PR_SET_TIMERSLACK_PID
> value has collided many times w/ upstream (first w/
> PR_SET_THP_DISABLE, and again w/ PR_MPX_ENABLE_MANAGEMENT).
>
> So to try to avoid further ABI trouble, I wanted to send this out
> for initial review to see if there were any major objections,
> or ideas for alternative approaches.
>
> Thoughts and feedback would be appreciated.
I am wondering if it would be more natural to make this a cgroup
property.. and have a way for threads to inherit their cgroup
effective value.
it'll fit more natural in many places than just a per pid setting.
(I have nothing against it per se other than that I think the
security check is wrong; I fully expected to be on the level of
ptrace_may_access(PTRACE_MODE_ATTACH) or the like.. not just NICE.
you can seriously change task behavior with this by setting a 4 second
value or so.. much more than just with nice)
next prev parent reply other threads:[~2015-06-26 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 23:24 [RFC][PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread John Stultz
2015-06-26 1:21 ` Arjan van de Ven [this message]
2015-06-26 21:36 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558CA92A.50707@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=kandoiruchi@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=micha@cellrox.com \
--cc=orenl@cellrox.com \
--cc=romlem@android.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.