From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH 1/1] gpu/drm: remove unnecessary check before kfree Date: Fri, 26 Jun 2015 15:46:33 +0900 Message-ID: <558CF549.7030909@daenzer.net> References: <1435299946-4610-1-git-send-email-maninder1.s@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id E8F786ED47 for ; Thu, 25 Jun 2015 23:46:40 -0700 (PDT) In-Reply-To: <1435299946-4610-1-git-send-email-maninder1.s@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maninder Singh Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pankaj.m@samsung.com List-Id: dri-devel@lists.freedesktop.org T24gMjYuMDYuMjAxNSAxNToyNSwgTWFuaW5kZXIgU2luZ2ggd3JvdGU6Cj4ga2ZyZWUoTlVMTCkg aXMgc2FmZSBhbmQgdGhpcyBjaGVjayBpcyBwcm9iYWJseSBub3QgcmVxdWlyZWQKPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBNYW5pbmRlciBTaW5naCA8bWFuaW5kZXIxLnNAc2Ftc3VuZy5jb20+Cj4gUmV2 aWV3ZWQtYnk6IFZhbmVldCBOYXJhbmcgPHYubmFyYW5nQHNhbXN1bmcuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgfCAgICAzICstLQo+ICAx IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IGluZGV4IGZlYzQ4N2QuLmE4 NWNkMDggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rl dmljZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5j Cj4gQEAgLTE1NzUsOCArMTU3NSw3IEBAIHZvaWQgYW1kZ3B1X2RldmljZV9maW5pKHN0cnVjdCBh bWRncHVfZGV2aWNlICphZGV2KQo+ICAJYW1kZ3B1X2ZlbmNlX2RyaXZlcl9maW5pKGFkZXYpOwo+ ICAJYW1kZ3B1X2ZiZGV2X2ZpbmkoYWRldik7Cj4gIAlyID0gYW1kZ3B1X2ZpbmkoYWRldik7Cj4g LQlpZiAoYWRldi0+aXBfYmxvY2tfZW5hYmxlZCkKPiAtCQlrZnJlZShhZGV2LT5pcF9ibG9ja19l bmFibGVkKTsKPiArCWtmcmVlKGFkZXYtPmlwX2Jsb2NrX2VuYWJsZWQpOwo+ICAJYWRldi0+aXBf YmxvY2tfZW5hYmxlZCA9IE5VTEw7Cj4gIAlhZGV2LT5hY2NlbF93b3JraW5nID0gZmFsc2U7Cj4g IAkvKiBmcmVlIGkyYyBidXNlcyAqLwo+IAoKVGhlIHNob3J0bG9nIHByZWZpeCBvZiBib3RoIHlv dXIgcGF0Y2hlcyBzaG91bGQgYmUgImRybS9hbWRncHU6IiBpbnN0ZWFkCm9mICJncHUvZHJtOiIu IFdpdGggdGhhdCBmaXhlZCwgYm90aCBhcmUKClJldmlld2VkLWJ5OiBNaWNoZWwgRMOkbnplciA8 bWljaGVsLmRhZW56ZXJAYW1kLmNvbT4KCgotLSAKRWFydGhsaW5nIE1pY2hlbCBEw6RuemVyICAg ICAgICAgICAgICAgfCAgICAgICAgICAgICAgIGh0dHA6Ly93d3cuYW1kLmNvbQpMaWJyZSBzb2Z0 d2FyZSBlbnRodXNpYXN0ICAgICAgICAgICAgIHwgICAgICAgICAgICAgTWVzYSBhbmQgWCBkZXZl bG9wZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbbFZGyG (ORCPT ); Fri, 26 Jun 2015 02:54:06 -0400 Received: from darkcity.gna.ch ([195.226.6.51]:51361 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750993AbbFZGx7 (ORCPT ); Fri, 26 Jun 2015 02:53:59 -0400 X-Greylist: delayed 438 seconds by postgrey-1.27 at vger.kernel.org; Fri, 26 Jun 2015 02:53:59 EDT Subject: Re: [PATCH 1/1] gpu/drm: remove unnecessary check before kfree To: Maninder Singh References: <1435299946-4610-1-git-send-email-maninder1.s@samsung.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, pankaj.m@samsung.com From: =?UTF-8?Q?Michel_D=c3=a4nzer?= X-Enigmail-Draft-Status: N1110 Message-ID: <558CF549.7030909@daenzer.net> Date: Fri, 26 Jun 2015 15:46:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.0 MIME-Version: 1.0 In-Reply-To: <1435299946-4610-1-git-send-email-maninder1.s@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.06.2015 15:25, Maninder Singh wrote: > kfree(NULL) is safe and this check is probably not required > > Signed-off-by: Maninder Singh > Reviewed-by: Vaneet Narang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index fec487d..a85cd08 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev) > amdgpu_fence_driver_fini(adev); > amdgpu_fbdev_fini(adev); > r = amdgpu_fini(adev); > - if (adev->ip_block_enabled) > - kfree(adev->ip_block_enabled); > + kfree(adev->ip_block_enabled); > adev->ip_block_enabled = NULL; > adev->accel_working = false; > /* free i2c buses */ > The shortlog prefix of both your patches should be "drm/amdgpu:" instead of "gpu/drm:". With that fixed, both are Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer