All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing
@ 2015-06-26  6:24 ` Maninder Singh
  0 siblings, 0 replies; 8+ messages in thread
From: Maninder Singh @ 2015-06-26  6:24 UTC (permalink / raw)
  To: airlied, alexander.deucher, christian.koenig, michel.daenzer,
	monk.liu, maarten.lankhorst, dri-devel, linux-kernel
  Cc: Maninder Singh, pankaj.m

Use kzalloc rather than kcalloc(1.. for allocating
one thing.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Vaneet Narang <v.narang@samsung.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index d3706a4..dd3415d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
 		return 0;
 
 	if (gtt && gtt->userptr) {
-		ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
+		ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
 		if (!ttm->sg)
 			return -ENOMEM;
 
-- 
1.7.9.5

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing
@ 2015-06-26  6:24 ` Maninder Singh
  0 siblings, 0 replies; 8+ messages in thread
From: Maninder Singh @ 2015-06-26  6:24 UTC (permalink / raw)
  To: airlied, alexander.deucher, christian.koenig, michel.daenzer,
	monk.liu, maarten.lankhorst, dri-devel, linux-kernel
  Cc: pankaj.m, Maninder Singh

Use kzalloc rather than kcalloc(1.. for allocating
one thing.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Vaneet Narang <v.narang@samsung.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index d3706a4..dd3415d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
 		return 0;
 
 	if (gtt && gtt->userptr) {
-		ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
+		ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
 		if (!ttm->sg)
 			return -ENOMEM;
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing
  2015-06-26  6:24 ` Maninder Singh
@ 2015-06-26  7:34   ` Daniel Vetter
  -1 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2015-06-26  7:34 UTC (permalink / raw)
  To: Maninder Singh
  Cc: michel.daenzer, linux-kernel, dri-devel, maarten.lankhorst,
	alexander.deucher, christian.koenig, monk.liu, pankaj.m

On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
> Use kzalloc rather than kcalloc(1.. for allocating
> one thing.
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index d3706a4..dd3415d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
>  		return 0;
>  
>  	if (gtt && gtt->userptr) {
> -		ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
> +		ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
>  		if (!ttm->sg)
>  			return -ENOMEM;
>  
> -- 
> 1.7.9.5
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing
@ 2015-06-26  7:34   ` Daniel Vetter
  0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2015-06-26  7:34 UTC (permalink / raw)
  To: Maninder Singh
  Cc: airlied, alexander.deucher, christian.koenig, michel.daenzer,
	monk.liu, maarten.lankhorst, dri-devel, linux-kernel, pankaj.m

On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
> Use kzalloc rather than kcalloc(1.. for allocating
> one thing.
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index d3706a4..dd3415d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
>  		return 0;
>  
>  	if (gtt && gtt->userptr) {
> -		ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
> +		ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
>  		if (!ttm->sg)
>  			return -ENOMEM;
>  
> -- 
> 1.7.9.5
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing
  2015-06-26  7:34   ` Daniel Vetter
@ 2015-06-26  7:37     ` Daniel Vetter
  -1 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2015-06-26  7:37 UTC (permalink / raw)
  To: Maninder Singh
  Cc: michel.daenzer, linux-kernel, dri-devel, maarten.lankhorst,
	alexander.deucher, christian.koenig, monk.liu, pankaj.m

On Fri, Jun 26, 2015 at 09:34:43AM +0200, Daniel Vetter wrote:
> On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
> > Use kzalloc rather than kcalloc(1.. for allocating
> > one thing.
> > 
> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> 
> Applied to drm-misc, thanks.

And dropped again since I didn't realize this is for amdgpu and not core
drm.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing
@ 2015-06-26  7:37     ` Daniel Vetter
  0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2015-06-26  7:37 UTC (permalink / raw)
  To: Maninder Singh
  Cc: airlied, alexander.deucher, christian.koenig, michel.daenzer,
	monk.liu, maarten.lankhorst, dri-devel, linux-kernel, pankaj.m

On Fri, Jun 26, 2015 at 09:34:43AM +0200, Daniel Vetter wrote:
> On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
> > Use kzalloc rather than kcalloc(1.. for allocating
> > one thing.
> > 
> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> 
> Applied to drm-misc, thanks.

And dropped again since I didn't realize this is for amdgpu and not core
drm.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing
  2015-06-26  7:37     ` Daniel Vetter
@ 2015-06-26  7:40       ` Christian König
  -1 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2015-06-26  7:40 UTC (permalink / raw)
  To: Maninder Singh, airlied, alexander.deucher, michel.daenzer,
	monk.liu, maarten.lankhorst, dri-devel, linux-kernel, pankaj.m

On 26.06.2015 09:37, Daniel Vetter wrote:
> On Fri, Jun 26, 2015 at 09:34:43AM +0200, Daniel Vetter wrote:
>> On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
>>> Use kzalloc rather than kcalloc(1.. for allocating
>>> one thing.
>>>
>>> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>>> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>> Applied to drm-misc, thanks.
> And dropped again since I didn't realize this is for amdgpu and not core
> drm.

I was just about to complain on the confusing patch subject :)

So please fix the subject lines of both your patches to something like 
"drm/amdgpu:" and send them out again.

With that fixed both patches are Reviewed-by: Christian König 
<christian.koenig@amd.com>

Regards,
Christian.

> -Daniel

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing
@ 2015-06-26  7:40       ` Christian König
  0 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2015-06-26  7:40 UTC (permalink / raw)
  To: Maninder Singh, airlied, alexander.deucher, michel.daenzer,
	monk.liu, maarten.lankhorst, dri-devel, linux-kernel, pankaj.m

On 26.06.2015 09:37, Daniel Vetter wrote:
> On Fri, Jun 26, 2015 at 09:34:43AM +0200, Daniel Vetter wrote:
>> On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
>>> Use kzalloc rather than kcalloc(1.. for allocating
>>> one thing.
>>>
>>> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>>> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>> Applied to drm-misc, thanks.
> And dropped again since I didn't realize this is for amdgpu and not core
> drm.

I was just about to complain on the confusing patch subject :)

So please fix the subject lines of both your patches to something like 
"drm/amdgpu:" and send them out again.

With that fixed both patches are Reviewed-by: Christian König 
<christian.koenig@amd.com>

Regards,
Christian.

> -Daniel


^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-06-26  7:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-26  6:24 [PATCH 1/1] gpu/drm: use kzalloc for allocating one thing Maninder Singh
2015-06-26  6:24 ` Maninder Singh
2015-06-26  7:34 ` Daniel Vetter
2015-06-26  7:34   ` Daniel Vetter
2015-06-26  7:37   ` Daniel Vetter
2015-06-26  7:37     ` Daniel Vetter
2015-06-26  7:40     ` Christian König
2015-06-26  7:40       ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.