From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v4][PATCH 12/19] tools/libxl: passes rdm
	reservation policy
Date: Fri, 26 Jun 2015 16:53:47 +0800
Message-ID: <558D131B.9040902@intel.com>
References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com>	
	<1435053450-25131-13-git-send-email-tiejun.chen@intel.com>
	<1435234518.32500.75.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1435234518.32500.75.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

>>   B<BDF> is the PCI Bus/Device/Function of the physical device to pass-through.
>> +B<rdm policy> is about how to handle conflict between reserving reserved device
>
> s/is about/specifies/

Okay.

and I think s/between/while/
>
>> +memory and guest address space. "strict" means an unsolved conflict leads to
>
> I think you mean "in" rather than "and"?

Actually, as you see I was originally trying to say " conflict between A 
and B".

What about this?

B<rdm policy> specifies how to handle conflict between reserved device 
memory space and guest address space...

>
>
>> +immediate VM crash, while "relaxed" allows VM moving forward with a warning
>> +message thrown out. Here "strict" is default.
>
> "The default is "strict"".

Okay.

>
> You've repeated the list of allowed values for this two or three times
> now in the various docs, perhaps try and centralise on one definition
> and cross reference instead?
>

I will delete this last sentence and add this,

Please refer "reserve" option to the rdm option in xl.cfg.5.txt.

Thanks
Tiejun