From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/nHVM: generic hook adjustments Date: Fri, 26 Jun 2015 10:09:53 +0100 Message-ID: <558D16E1.8010201@citrix.com> References: <558D313C020000780008A126@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z8Pe8-0002QB-39 for xen-devel@lists.xenproject.org; Fri, 26 Jun 2015 09:10:04 +0000 In-Reply-To: <558D313C020000780008A126@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Kevin Tian , Keir Fraser , suravee.suthikulpanit@amd.com, Eddie Dong , Aravind Gopalakrishnan , Jun Nakajima , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On 26/06/15 10:02, Jan Beulich wrote: > Some of the generic hooks were unused altogether - drop them. > > Some of the hooks were used only to handle calls from the specific > vendor's code (SVM) - drop them too. > > Several more hooks were pointlessly implementaed as out-of-line > functions, when most (all?) other HVM hooks use inline ones - make > them inlines. None of them are implemented by only one of SVM or VMX, > so also drop the conditionals. Funnily nhvm_vmcx_hap_enabled(), having > return type bool_t, nevertheless returned -EOPNOTSUPP. > > nhvm_vmcx_guest_intercepts_trap() and its hook and implementations are > being made return bool_t, as they should have been from the beginning > (its sole caller only checks for a non-zero result). > > Finally, make static whatever can as a result be static. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper That is a healthy quantity of deletion.