From mboxrd@z Thu Jan 1 00:00:00 1970 From: Varka Bhadram Subject: Re: [v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver Date: Fri, 26 Jun 2015 18:01:53 +0530 Message-ID: <558D4639.8000102@gmail.com> References: <1435309330-50725-1-git-send-email-shobhit.kumar@intel.com> <1435309330-50725-6-git-send-email-shobhit.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1435309330-50725-6-git-send-email-shobhit.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shobhit Kumar , linux-pwm , intel-gfx , linux-kernel , dri-devel , linux-gpio Cc: Alexandre Courbot , Paul Bolle , Samuel Ortiz , Povilas Staniulis , Jani Nikula , Linus Walleij , Paul Gortmaker , bloften80@gmail.com, David Airlie , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Lee Jones List-Id: linux-gpio@vger.kernel.org T24gMDYvMjYvMjAxNSAwMjozMiBQTSwgU2hvYmhpdCBLdW1hciB3cm90ZToKPiBUaGUgQ3J5c3Rh bGNvdmUgUE1JQyBwcm92aWRlcyB0aHJlZSBQV00gc2lnbmFscyBhbmQgdGhpcyBkcml2ZXIgZXhw b3J0cwo+IG9uZSBvZiB0aGVtIG9uIHRoZSBCWVQgcGxhdGZvcm0gd2hpY2ggaXMgdXNlZCB0byBj b250cm9sIGJhY2tsaWdodCBmb3IKPiBEU0kgcGFuZWwuIFRoaXMgaXMgcGxhdGZvcm0gZGV2aWNl IGltcGxlbWVudGF0aW9uIG9mIHRoZSBkcml2ZXJzL21mZAo+IGNlbGwgZGV2aWNlIGZvciBDUkMg UE1JQy4KPgo+IENDOiBTYW11ZWwgT3J0aXogPHNhbWVvQGxpbnV4LmludGVsLmNvbT4KPiBDYzog TGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPgo+IENjOiBBbGV4YW5kcmUg Q291cmJvdCA8Z251cm91QGdtYWlsLmNvbT4KPiBDYzogVGhpZXJyeSBSZWRpbmcgPHRoaWVycnku cmVkaW5nQGdtYWlsLmNvbT4KPiBDYzogUGF1bCBCb2xsZSA8cGVib2xsZUB0aXNjYWxpLm5sPgo+ IENjOiBQYXVsIEdvcnRtYWtlciA8cGF1bC5nb3J0bWFrZXJAd2luZHJpdmVyLmNvbT4KPiBUZXN0 ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogU2hvYmhpdCBLdW1hciA8c2hvYmhpdC5rdW1hckBpbnRlbC5jb20+Cj4g LS0tCj4gdjI6IFVzZSB0aGUgZXhpc3RpbmcgY29uZmlnIGNhbGxiYWNrIHdpdGggZHV0eV9ucyBh bmQgcGVyaW9kX25zKFRoaWVycnkpCj4KPiB2MzogQ29ycmVjdCB0aGUgc3ViamVjdCBsaW5lIChM ZWUgam9uZXMpCj4KPiB2NDogQWRkcmVzcyBjb21tZW50IGJ5IFRoaWVycnkgJiBQYXVsCj4gICAg ICAtIENvbW1pdCBtZXNzYWdlIHVwZGF0ZSBhbmQgZml4ZXMgZm9yIGZldyBzeW50YXggZXJyb3Jz Cj4gICAgICAtIEFkZCBQV01fQ1JDIGluIEtjb25maWcgYW5kIE1ha2VmaWxlIHNvcnRlZCBhbHBo YWJldGljYWxseQo+ICAgICAgLSBVc2UgdGhlIFBXTV9CQVNFX0NMSyBhcyA2MDAwMDAwIGZvciBi ZXR0ZXIgY29kZSByZWFkYWJpbGl0eQo+ICAgICAgLSBSZW1vdmUgdGhlIHJlZHVuZGFudCBydWxl IG9mIHRocmVlIHdoaWxlIGNhbGN1bGF0aW5nIHB3bSBsZXZlbAo+ICAgICAgLSBVc2UgdGhlIHBs YXRmb3JtX2RldmljZSBpbiBwd21fY2hpcAo+ICAgICAgLSBVc2UgYnVpbGluX3BsYXRmb3JtX2Ry aXZlcgo+Cj4gdjU6IEFkZHJlc3MgY29tbWVudHMgYnkgVmFya2EKPiAgICAgIC0gTWFrZSB0aGUg Yml0IGRlZmluaXRpb24gdXNpbmcgQklUIG1hY3JvCj4gICAgICAtIHJlb3JkZXIgcHJvYmUgYW5k IHJlbW92ZSBjb2RlIHRvIGRpcmVjdGx5IHJldHVybiBmcm9tIHB3bWNoaXBfYWRkL3JlbW92ZQo+ Cj4gICBkcml2ZXJzL3B3bS9LY29uZmlnICAgfCAgIDcgKysrCj4gICBkcml2ZXJzL3B3bS9NYWtl ZmlsZSAgfCAgIDEgKwo+ICAgZHJpdmVycy9wd20vcHdtLWNyYy5jIHwgMTQzICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gICAzIGZpbGVzIGNoYW5n ZWQsIDE1MSBpbnNlcnRpb25zKCspCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9wd20v cHdtLWNyYy5jCgpSZXZpZXdlZC1ieTogVmFya2EgQmhhZHJhbSA8dmFya2FiaGFkcmFtQGdtYWls LmNvbT4KCi0tIApCZXN0IHJlZ2FyZHMsClZhcmthIEJoYWRyYW0uCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbbFZMcp (ORCPT ); Fri, 26 Jun 2015 08:32:45 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34174 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004AbbFZMc3 (ORCPT ); Fri, 26 Jun 2015 08:32:29 -0400 Message-ID: <558D4639.8000102@gmail.com> Date: Fri, 26 Jun 2015 18:01:53 +0530 From: Varka Bhadram User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Shobhit Kumar , linux-pwm , intel-gfx , linux-kernel , dri-devel , linux-gpio CC: Paul Bolle , Jani Nikula , Samuel Ortiz , Alexandre Courbot , David Airlie , Povilas Staniulis , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Lee Jones , Linus Walleij , Paul Gortmaker , bloften80@gmail.com Subject: Re: [v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver References: <1435309330-50725-1-git-send-email-shobhit.kumar@intel.com> <1435309330-50725-6-git-send-email-shobhit.kumar@intel.com> In-Reply-To: <1435309330-50725-6-git-send-email-shobhit.kumar@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/26/2015 02:32 PM, Shobhit Kumar wrote: > The Crystalcove PMIC provides three PWM signals and this driver exports > one of them on the BYT platform which is used to control backlight for > DSI panel. This is platform device implementation of the drivers/mfd > cell device for CRC PMIC. > > CC: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Cc: Paul Bolle > Cc: Paul Gortmaker > Tested-by: Ville Syrjälä > Signed-off-by: Shobhit Kumar > --- > v2: Use the existing config callback with duty_ns and period_ns(Thierry) > > v3: Correct the subject line (Lee jones) > > v4: Address comment by Thierry & Paul > - Commit message update and fixes for few syntax errors > - Add PWM_CRC in Kconfig and Makefile sorted alphabetically > - Use the PWM_BASE_CLK as 6000000 for better code readability > - Remove the redundant rule of three while calculating pwm level > - Use the platform_device in pwm_chip > - Use builin_platform_driver > > v5: Address comments by Varka > - Make the bit definition using BIT macro > - reorder probe and remove code to directly return from pwmchip_add/remove > > drivers/pwm/Kconfig | 7 +++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-crc.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 151 insertions(+) > create mode 100644 drivers/pwm/pwm-crc.c Reviewed-by: Varka Bhadram -- Best regards, Varka Bhadram.