From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
"David S. Miller" <davem@davemloft.net>,
Antonio Borneo <borneo.antonio@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA
Date: Fri, 26 Jun 2015 16:21:24 +0300 [thread overview]
Message-ID: <558D51D4.9060202@cogentembedded.com> (raw)
In-Reply-To: <1435320502-4951-1-git-send-email-geert@linux-m68k.org>
Hello.
On 6/26/2015 3:08 PM, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_set_mask" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_mapping_error" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-rhine.ko] undefined!
> ERROR: "dma_map_page" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined!
> Before, the symbols depended implicitly on HAS_DMA through PCI or
> USE_OF. Add explicit dependencies on HAS_DMA to fix this.
> Fixes: commit b7d3282a245f4428 ("net: via/Kconfig: replace USE_OF with OF_???")
Fixes: b7d3282a245f ("net: via/Kconfig: replace USE_OF with OF_???")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
WBR, Sergei
next prev parent reply other threads:[~2015-06-26 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 12:08 [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA Geert Uytterhoeven
2015-06-26 13:21 ` Sergei Shtylyov [this message]
2015-06-27 6:38 ` Antonio Borneo
2015-06-29 3:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D51D4.9060202@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=borneo.antonio@gmail.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.