From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v11 6/9] xen: Add ring 3 vmware_port support Date: Fri, 26 Jun 2015 10:54:46 -0400 Message-ID: <558D67B6.8090303@Gmail.com> References: <1432309826-6420-1-git-send-email-dslutz@verizon.com> <1432309826-6420-7-git-send-email-dslutz@verizon.com> <5589A211020000780008880C@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5589A211020000780008880C@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Don Slutz Cc: Kevin Tian , Keir Fraser , Ian Campbell , Stefano Stabellini , George Dunlap , Andrew Cooper , Tim Deegan , xen-devel@lists.xen.org, Eddie Dong , Aravind Gopalakrishnan , Jun Nakajima , Suravee Suthikulpanit , Boris Ostrovsky , Ian Jackson List-Id: xen-devel@lists.xenproject.org On 06/23/15 12:14, Jan Beulich wrote: >>>> On 22.05.15 at 17:50, wrote: >> Summary is that VMware treats "in (%dx),%eax" (or "out %eax,(%dx)") >> to port 0x5658 specially. Note: since many operations return data >> in EAX, "in (%dx),%eax" is the one to use. The other lengths like >> "in (%dx),%al" will still do things, only AL part of EAX will be >> changed. For "out %eax,(%dx)" of all lengths, EAX will remain >> unchanged. >> >> This instruction is allowed to be used from ring 3. To >> support this the vmexit for GP needs to be enabled. I have not >> fully tested that nested HVM is doing the right thing for this. >> >> Enable no-fault of pio in x86_emulate for VMware port >> >> Also adjust the emulation registers after doing a VMware >> backdoor operation. >> >> Add new routine hvm_emulate_one_gp() to be used by the #GP fault >> handler. >> >> Some of the best info is at: >> >> https://sites.google.com/site/chitchatvmback/backdoor >> >> Signed-off-by: Don Slutz > As there don't seem to be enough convincing arguments for this to > be worthwhile, I'm going to drop this and subsequent patches from > my list of things to look at. Would you mind following George's (at > least I think it was him) advice to post a shortened series with all > review comments taken care of, so that at least the ring 0 pieces > could go in for 4.6? Sure, I was just about to post v12 (last check was a rebase with failed): commit 65bb47fb732265f704d4ec6616076ec74771a6eb Author: Paul Durrant Date: Tue Jun 23 18:08:32 2015 +0200 Needs more then simple merge. Will post when ready. -Don Slutz > Thanks, Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel