From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] x86/nHVM: generic hook adjustments
Date: Fri, 26 Jun 2015 10:58:20 -0400
Message-ID: <558D688C.7040706@oracle.com>
References: <558D313C020000780008A126@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <boris.ostrovsky@oracle.com>) id 1Z8V5Q-0008Ld-AS
	for xen-devel@lists.xenproject.org; Fri, 26 Jun 2015 14:58:36 +0000
In-Reply-To: <558D313C020000780008A126@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, suravee.suthikulpanit@amd.com, Andrew Cooper <andrew.cooper3@citrix.com>, Eddie Dong <eddie.dong@intel.com>, Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 06/26/2015 05:02 AM, Jan Beulich wrote:
>   
> -uint64_t nsvm_vcpu_guestcr3(struct vcpu *v)
> -{
> -    return vcpu_nestedsvm(v).ns_vmcb_guestcr3;
> -}
> -

If this is removed then I don't see why we still need ns_vmcb_guestcr3, 
I don't see it being used anywhere except for being assigned a value.

-boris