All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
	stefano.stabellini@eu.citrix.com,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	tim@xen.org, xen-devel@lists.xen.org,
	Jan Beulich <JBeulich@suse.com>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v2] xen: arm: Log a warning message when a deprecated hypercall is used
Date: Fri, 26 Jun 2015 17:00:08 +0200	[thread overview]
Message-ID: <558D68F8.2010000@citrix.com> (raw)
In-Reply-To: <1435330521.32500.198.camel@citrix.com>



On 26/06/2015 16:55, Ian Campbell wrote:
>>> + * Only use this for hypercalls which were deprecated (i.e. replaced
>>> + * by something else) before Xen on ARM was created, i.e. *not* for
>>> + * hypercalls which are simply not yet used on ARM.
>>> + */
>>> +#define HYPERCALL_DEPRECATED(_name, _nr_args)                   \
>>
>> I guess the parameter __nr_args is just here for completeness?
>
> It goes into the hypercall table and is used to clobber the arguments in
> debug mode, just like for a non-deprecated hypercall.

Thanks, you can keep the Reviewed-by then.

Regards,

-- 
Julien Grall

  reply	other threads:[~2015-06-26 15:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26 11:39 [PATCH v2] xen: arm: Log a warning message when a deprecated hypercall is used Ian Campbell
2015-06-26 14:43 ` Julien Grall
2015-06-26 14:55   ` Ian Campbell
2015-06-26 15:00     ` Julien Grall [this message]
2015-06-30 14:18       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558D68F8.2010000@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=anthony.perard@citrix.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.