From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8WnZ-0002Uc-HP for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:48:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8WnU-0001gf-ID for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:48:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39981 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8WnU-0001gR-Bx for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:48:12 -0400 Message-ID: <558D824B.3080606@suse.de> Date: Fri, 26 Jun 2015 18:48:11 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1434394190-13837-1-git-send-email-peter.maydell@linaro.org> <1434394190-13837-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1434394190-13837-2-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] target-arm: Split DISAS_YIELD from DISAS_WFE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org, =?ISO-8859-15?Q?Alex_Z=FCpke?= Am 15.06.2015 um 20:49 schrieb Peter Maydell: > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c > index 7fa32c4..5f06ca0 100644 > --- a/target-arm/op_helper.c > +++ b/target-arm/op_helper.c > @@ -334,6 +334,18 @@ void HELPER(wfe)(CPUARMState *env) > cpu_loop_exit(cs); > } > =20 > +void HELPER(yield)(CPUARMState *env) > +{ > + CPUState *cs =3D CPU(arm_env_get_cpu(env)); I'd appreciate if you could split this into two lines when applying. No respin needed for that. > + > + /* This is a non-trappable hint instruction, so semantically > + * different from WFE even though we currently implement it > + * identically. Yield control back to the top level loop. > + */ > + cs->exception_index =3D EXCP_YIELD; > + cpu_loop_exit(cs); > +} > + > /* Raise an internal-to-QEMU exception. This is limited to only > * those EXCP values which are special cases for QEMU to interrupt > * execution and not to be used for exceptions which are passed to [snip] Looks fine otherwise. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)