From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 6/6] xen: arm: Import of_bus PCI entry from Linux (as a dt_bus entry) Date: Fri, 26 Jun 2015 20:08:10 +0200 Message-ID: <558D950A.7060101@citrix.com> References: <1431084401.2660.440.camel@citrix.com> <1431084420-14372-6-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1431084420-14372-6-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 08/05/2015 13:27, Ian Campbell wrote: > This provides specific handlers for the PCI bus relating to matching > and translating. It's mostly similar to the defaults but includes some > additional error checks and other PCI specific bits. I though the previous patch (#5) was enough to handle PCI. May I ask why we need it? > Functions/types renamed and reindented (because apparently we do > that for these). My mistake, when I first port the functions from Linux I changed the name and the coding style to match the existent functions in xen/common/device_tree.c All the functions to work directly on the DT blob have been moved in a separate file (arch/arm/bootfdt.c), so this file is mostly Linux code. I'm thinking to resync it correctly for Xen 4.7. > Needs a selection of IORESOURCE_* defines, which I've taken from Linux > and have included locally for now until we figure out where else they > might be needed. Regards, -- Julien Grall