All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Grandel <fgrandel@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_ldisc: backport changes
Date: Fri, 26 Jun 2015 20:42:48 +0200	[thread overview]
Message-ID: <558D9D28.1010200@gmail.com> (raw)
In-Reply-To: <C64B93E8-D2FE-421F-B2D7-87A9C6AC22BA@holtmann.org>

On 06/26/2015 08:30 PM, Marcel Holtmann wrote:
> Hi Florian,
>
>> The references to tty->termios in hci_ldisc were not backports
>> compatible. Introducing #define statements to make this file compile
>> against earlier kernel versions.
>>
>> Signed-off-by: Florian Grandel <fgrandel@gmail.com>
>> ---
>> drivers/bluetooth/hci_ldisc.c | 19 ++++++++++++++++++-
>> 1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
>> index 177dd69..14d08b1 100644
>> --- a/drivers/bluetooth/hci_ldisc.c
>> +++ b/drivers/bluetooth/hci_ldisc.c
>> @@ -24,6 +24,7 @@
>>   */
>>
>> #include <linux/module.h>
>> +#include <linux/version.h>
>>
>> #include <linux/kernel.h>
>> #include <linux/init.h>
>> @@ -277,7 +278,11 @@ void hci_uart_set_flow_control(struct hci_uart *hu, bool enable)
>>
>> 	if (enable) {
>> 		/* Disable hardware flow control */
>> +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,7,0))
>> 		ktermios = tty->termios;
>> +#else
>> +		ktermios = *tty->termios;
>> +#endif
>
> such a patch is not acceptable upstream. This is something that the backports projects has to keep out-of-tree.

ah ok - didn't know that, sorry

  reply	other threads:[~2015-06-26 18:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26 18:13 [PATCH] Bluetooth: hci_ldisc: backport changes Florian Grandel
2015-06-26 18:30 ` Marcel Holtmann
2015-06-26 18:42   ` Florian Grandel [this message]
2015-06-26 19:07   ` Fwd: " Florian Grandel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558D9D28.1010200@gmail.com \
    --to=fgrandel@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.