All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/2] imx: mx6 remove duplicated enable_cspi_clock
Date: Sun, 28 Jun 2015 10:53:20 +0200	[thread overview]
Message-ID: <558FB600.9030109@denx.de> (raw)
In-Reply-To: <1435195985-11753-1-git-send-email-Peng.Fan@freescale.com>

Hi Peng,

On 25/06/2015 03:33, Peng Fan wrote:
> enable_spi_clock does the same thing with enable_cspi_clock, so
> remove enable_cspi_clock.
> Remove enable_cspi_clock prototype in header file
> convert cm_fx6/spl.c to use enable_spi_clk
> 
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> ---
>  arch/arm/cpu/armv7/mx6/clock.c        | 19 -------------------
>  arch/arm/include/asm/arch-mx6/clock.h |  1 -
>  board/compulab/cm_fx6/spl.c           |  2 +-
>  3 files changed, 1 insertion(+), 21 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
> index ae99945..1134770 100644
> --- a/arch/arm/cpu/armv7/mx6/clock.c
> +++ b/arch/arm/cpu/armv7/mx6/clock.c
> @@ -102,25 +102,6 @@ void enable_uart_clk(unsigned char enable)
>  }
>  #endif
>  
> -#ifdef CONFIG_SPI
> -/* spi_num can be from 0 - 4 */
> -int enable_cspi_clock(unsigned char enable, unsigned spi_num)
> -{
> -	u32 mask;
> -
> -	if (spi_num > 4)
> -		return -EINVAL;
> -
> -	mask = MXC_CCM_CCGR_CG_MASK << (spi_num * 2);
> -	if (enable)
> -		setbits_le32(&imx_ccm->CCGR1, mask);
> -	else
> -		clrbits_le32(&imx_ccm->CCGR1, mask);
> -
> -	return 0;
> -}
> -#endif
> -
>  #ifdef CONFIG_MMC
>  int enable_usdhc_clk(unsigned char enable, unsigned bus_num)
>  {
> diff --git a/arch/arm/include/asm/arch-mx6/clock.h b/arch/arm/include/asm/arch-mx6/clock.h
> index a6de5ee..7b3bbb8 100644
> --- a/arch/arm/include/asm/arch-mx6/clock.h
> +++ b/arch/arm/include/asm/arch-mx6/clock.h
> @@ -57,7 +57,6 @@ void hab_caam_clock_enable(unsigned char enable);
>  void enable_ocotp_clk(unsigned char enable);
>  void enable_usboh3_clk(unsigned char enable);
>  void enable_uart_clk(unsigned char enable);
> -int enable_cspi_clock(unsigned char enable, unsigned spi_num);
>  int enable_usdhc_clk(unsigned char enable, unsigned bus_num);
>  int enable_sata_clock(void);
>  void disable_sata_clock(void);
> diff --git a/board/compulab/cm_fx6/spl.c b/board/compulab/cm_fx6/spl.c
> index 5b4b76f..d94ced9 100644
> --- a/board/compulab/cm_fx6/spl.c
> +++ b/board/compulab/cm_fx6/spl.c
> @@ -303,7 +303,7 @@ static void cm_fx6_setup_uart(void)
>  static void cm_fx6_setup_ecspi(void)
>  {
>  	cm_fx6_set_ecspi_iomux();
> -	enable_cspi_clock(1, 0);
> +	enable_spi_clk(1, 0);
>  }
>  #else
>  static void cm_fx6_setup_ecspi(void) { }
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2015-06-28  8:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25  1:33 [U-Boot] [PATCH V2 1/2] imx: mx6 remove duplicated enable_cspi_clock Peng Fan
2015-06-25  1:33 ` [U-Boot] [PATCH V2 2/2] imx: mx6 add i2c4 clock support for i.MX6SX Peng Fan
2015-06-28  8:52   ` Stefano Babic
2015-06-29  1:33     ` Peng Fan
2015-06-29  7:13       ` Stefano Babic
2015-06-29  7:29         ` Peng Fan
2015-06-28  8:53 ` Stefano Babic [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-07-01  9:01 [U-Boot] [PATCH V2 1/2] imx: mx6 remove duplicated enable_cspi_clock Peng Fan
2015-07-10  7:37 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558FB600.9030109@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.