All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ravi Teja <ravi.teja@ecolibriumenergy.com>
To: benjamin.romer@unisys.com, david.kershner@unisys.com
Cc: gregkh@linuxfoundation.com, jes.sorensen@redhat.com,
	dzickus@redhat.com, sparmaintainer@unisys.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings
Date: Sun, 28 Jun 2015 22:24:49 +0530	[thread overview]
Message-ID: <559026D9.3090704@ecolibriumenergy.com> (raw)


This patch fixes checkpatch warnings

Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
---
 drivers/staging/unisys/visorbus/visorchipset.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index bb8087e..62f7f68 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1410,8 +1410,8 @@ visorchipset_chipset_ready(void)
 static int
 visorchipset_chipset_selftest(void)
 {
-    char env_selftest[20];
-    char *envp[] = { env_selftest, NULL };
+    static char env_selftest[20];
+    static const char * const envp[] = { env_selftest, NULL };
 
     sprintf(env_selftest, "SPARSP_SELFTEST=%d", 1);
     kobject_uevent_env(&visorchipset_platform_device.dev.kobj, KOBJ_CHANGE,
@@ -1559,9 +1559,9 @@ static void
 parahotplug_request_kickoff(struct parahotplug_request *req)
 {
     struct controlvm_message_packet *cmd = &req->msg.cmd;
-    char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40],
-        env_func[40];
-    char *envp[] = {
+    static char env_cmd[40], env_id[40], env_state[40], env_bus[40],
+            env_dev[40], env_func[40];
+    static const char * const envp[] = {
         env_cmd, env_id, env_state, env_bus, env_dev, env_func, NULL
     };
 
-- 
1.9.1


             reply	other threads:[~2015-06-28 16:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-28 16:54 Ravi Teja [this message]
2015-06-29  3:18 ` [PATCH]drivers:staging:visorbus:Fix checkpatch warnings Greg KH
2015-06-29  8:29 ` Dan Carpenter
2015-06-29 13:50 ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559026D9.3090704@ecolibriumenergy.com \
    --to=ravi.teja@ecolibriumenergy.com \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dzickus@redhat.com \
    --cc=gregkh@linuxfoundation.com \
    --cc=jes.sorensen@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.